ghndrx/k8s-game-2048
1
0
Fork 0
mirror of https://github.com/ghndrx/k8s-game-2048.git synced 2026-02-10 14:54:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct GitHub secrets for canonical domains in workflows

Browse Source 
- Fix smoke-test.yml to use DEV_CANONICAL_DOMAIN, STAGING_CANONICAL_DOMAIN, PROD_CANONICAL_DOMAIN
- Fix promote-to-production.yml domain references
- Fix deployment-status.yml domain references
- Update documentation to reflect correct secret names

The workflows were trying to use DEV_DOMAIN instead of DEV_CANONICAL_DOMAIN
which caused the smoke tests to fail. Canonical domains are the auto-generated
Knative service domains that the tests actually need to check.
This commit is contained in:
Greg
2025-07-01 17:41:51 -07:00
parent 7313b1d155
commit 504272e95b
4 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/promote-to-production.yml vendored
View File

@@ -102,9 +102,9 @@ jobs:
echo "### 🎮 Deployment Status" >> $GITHUB_STEP_SUMMARY
# Use canonical domain format (these are the Knative domains)
DEV_URL="https://${{ secrets.DEV_DOMAIN }}"
STAGING_URL="https://${{ secrets.STAGING_DOMAIN }}"
PROD_URL="https://${{ secrets.PROD_DOMAIN }}"
DEV_URL="https://${{ secrets.DEV_CANONICAL_DOMAIN }}"
STAGING_URL="https://${{ secrets.STAGING_CANONICAL_DOMAIN }}"
PROD_URL="https://${{ secrets.PROD_CANONICAL_DOMAIN }}"
echo "- **Development**: ✅ Live at $DEV_URL" >> $GITHUB_STEP_SUMMARY
echo "- **Staging**: ✅ Live at $STAGING_URL" >> $GITHUB_STEP_SUMMARY