ghndrx/k8s-game-2048
1
0
Fork 0
mirror of https://github.com/ghndrx/k8s-game-2048.git synced 2026-02-10 06:45:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct GitHub secrets for canonical domains in workflows

Browse Source 
- Fix smoke-test.yml to use DEV_CANONICAL_DOMAIN, STAGING_CANONICAL_DOMAIN, PROD_CANONICAL_DOMAIN
- Fix promote-to-production.yml domain references
- Fix deployment-status.yml domain references
- Update documentation to reflect correct secret names

The workflows were trying to use DEV_DOMAIN instead of DEV_CANONICAL_DOMAIN
which caused the smoke tests to fail. Canonical domains are the auto-generated
Knative service domains that the tests actually need to check.
This commit is contained in:
Greg
2025-07-01 17:41:51 -07:00
parent 7313b1d155
commit 504272e95b
4 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
.github/workflows/smoke-test.yml vendored
View File

@@ -44,15 +44,15 @@ jobs:
run: |
case "${{ matrix.environment }}" in
dev)
echo "CANONICAL_DOMAIN=https://${{ secrets.DEV_DOMAIN }}" >> $GITHUB_ENV
echo "CANONICAL_DOMAIN=https://${{ secrets.DEV_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
echo "ENV_NAME=development" >> $GITHUB_ENV
;;
staging)
echo "CANONICAL_DOMAIN=https://${{ secrets.STAGING_DOMAIN }}" >> $GITHUB_ENV
echo "CANONICAL_DOMAIN=https://${{ secrets.STAGING_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
echo "ENV_NAME=staging" >> $GITHUB_ENV
;;
prod)
echo "CANONICAL_DOMAIN=https://${{ secrets.PROD_DOMAIN }}" >> $GITHUB_ENV
echo "CANONICAL_DOMAIN=https://${{ secrets.PROD_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
echo "ENV_NAME=production" >> $GITHUB_ENV
;;
esac
@@ -157,9 +157,9 @@ jobs:
# Canonical domains (Knative domains only)
canonical_domains=(
"${{ secrets.DEV_DOMAIN }}"
"${{ secrets.STAGING_DOMAIN }}"
"${{ secrets.PROD_DOMAIN }}"
"${{ secrets.DEV_CANONICAL_DOMAIN }}"
"${{ secrets.STAGING_CANONICAL_DOMAIN }}"
"${{ secrets.PROD_CANONICAL_DOMAIN }}"
)
for domain in "${canonical_domains[@]}"; do
@@ -179,9 +179,9 @@ jobs:
# Canonical domains (Knative domains only)
canonical_domains=(
"${{ secrets.DEV_DOMAIN }}"
"${{ secrets.STAGING_DOMAIN }}"
"${{ secrets.PROD_DOMAIN }}"
"${{ secrets.DEV_CANONICAL_DOMAIN }}"
"${{ secrets.STAGING_CANONICAL_DOMAIN }}"
"${{ secrets.PROD_CANONICAL_DOMAIN }}"
)
for domain in "${canonical_domains[@]}"; do
@@ -231,9 +231,9 @@ jobs:
echo "### Tested Canonical Domains" >> $GITHUB_STEP_SUMMARY
# Use canonical domain format
DEV_URL="https://${{ secrets.DEV_DOMAIN }}"
STAGING_URL="https://${{ secrets.STAGING_DOMAIN }}"
PROD_URL="https://${{ secrets.PROD_DOMAIN }}"
DEV_URL="https://${{ secrets.DEV_CANONICAL_DOMAIN }}"
STAGING_URL="https://${{ secrets.STAGING_CANONICAL_DOMAIN }}"
PROD_URL="https://${{ secrets.PROD_CANONICAL_DOMAIN }}"
echo "- 🧪 Development: $DEV_URL" >> $GITHUB_STEP_SUMMARY
echo "- 🎭 Staging: $STAGING_URL" >> $GITHUB_STEP_SUMMARY