mirror of
https://github.com/ghndrx/k8s-game-2048.git
synced 2026-02-10 06:45:07 +00:00
fix: correct GitHub secrets for canonical domains in workflows
- Fix smoke-test.yml to use DEV_CANONICAL_DOMAIN, STAGING_CANONICAL_DOMAIN, PROD_CANONICAL_DOMAIN - Fix promote-to-production.yml domain references - Fix deployment-status.yml domain references - Update documentation to reflect correct secret names The workflows were trying to use DEV_DOMAIN instead of DEV_CANONICAL_DOMAIN which caused the smoke tests to fail. Canonical domains are the auto-generated Knative service domains that the tests actually need to check.
This commit is contained in:
Greg
12
.github/workflows/deployment-status.yml
vendored
12
.github/workflows/deployment-status.yml
vendored
@@ -15,7 +15,7 @@ jobs:
|
||||
- name: Check Development Status
|
||||
run: |
|
||||
echo "🧪 Checking Development Environment..."
|
||||
DEV_URL="https://${{ secrets.DEV_DOMAIN }}"
|
||||
DEV_URL="https://${{ secrets.DEV_CANONICAL_DOMAIN }}"
|
||||
|
||||
DEV_STATUS=$(curl -s -o /dev/null -w "%{http_code}" -L --max-time 30 "$DEV_URL" || echo "000")
|
||||
DEV_VERSION=$(curl -s -L --max-time 30 "$DEV_URL" | grep -o '<title>[^<]*</title>' | sed 's/<title>\(.*\)<\/title>/\1/' || echo "Unknown")
|
||||
@@ -28,7 +28,7 @@ jobs:
|
||||
- name: Check Staging Status
|
||||
run: |
|
||||
echo "🎭 Checking Staging Environment..."
|
||||
STAGING_URL="https://${{ secrets.STAGING_DOMAIN }}"
|
||||
STAGING_URL="https://${{ secrets.STAGING_CANONICAL_DOMAIN }}"
|
||||
|
||||
STAGING_STATUS=$(curl -s -o /dev/null -w "%{http_code}" -L --max-time 30 "$STAGING_URL" || echo "000")
|
||||
STAGING_VERSION=$(curl -s -L --max-time 30 "$STAGING_URL" | grep -o '<title>[^<]*</title>' | sed 's/<title>\(.*\)<\/title>/\1/' || echo "Unknown")
|
||||
@@ -41,7 +41,7 @@ jobs:
|
||||
- name: Check Production Status
|
||||
run: |
|
||||
echo "🚀 Checking Production Environment..."
|
||||
PROD_URL="https://${{ secrets.PROD_DOMAIN }}"
|
||||
PROD_URL="https://${{ secrets.PROD_CANONICAL_DOMAIN }}"
|
||||
|
||||
PROD_STATUS=$(curl -s -o /dev/null -w "%{http_code}" -L --max-time 30 "$PROD_URL" || echo "000")
|
||||
PROD_VERSION=$(curl -s -L --max-time 30 "$PROD_URL" | grep -o '<title>[^<]*</title>' | sed 's/<title>\(.*\)<\/title>/\1/' || echo "Unknown")
|
||||
@@ -64,7 +64,7 @@ jobs:
|
||||
else
|
||||
DEV_ICON="❌"
|
||||
fi
|
||||
echo "| 🧪 Development | $DEV_ICON HTTP $DEV_STATUS | $DEV_VERSION | https://${{ secrets.DEV_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
echo "| 🧪 Development | $DEV_ICON HTTP $DEV_STATUS | $DEV_VERSION | https://${{ secrets.DEV_CANONICAL_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
# Staging status
|
||||
if [ "$STAGING_STATUS" = "200" ]; then
|
||||
@@ -72,7 +72,7 @@ jobs:
|
||||
else
|
||||
STAGING_ICON="❌"
|
||||
fi
|
||||
echo "| 🎭 Staging | $STAGING_ICON HTTP $STAGING_STATUS | $STAGING_VERSION | https://${{ secrets.STAGING_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
echo "| 🎭 Staging | $STAGING_ICON HTTP $STAGING_STATUS | $STAGING_VERSION | https://${{ secrets.STAGING_CANONICAL_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
# Production status
|
||||
if [ "$PROD_STATUS" = "200" ]; then
|
||||
@@ -80,7 +80,7 @@ jobs:
|
||||
else
|
||||
PROD_ICON="❌"
|
||||
fi
|
||||
echo "| 🚀 Production | $PROD_ICON HTTP $PROD_STATUS | $PROD_VERSION | https://${{ secrets.PROD_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
echo "| 🚀 Production | $PROD_ICON HTTP $PROD_STATUS | $PROD_VERSION | https://${{ secrets.PROD_CANONICAL_DOMAIN }} |" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
echo "" >> $GITHUB_STEP_SUMMARY
|
||||
echo "### 🔧 Emergency Actions Available" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
6
.github/workflows/promote-to-production.yml
vendored
6
.github/workflows/promote-to-production.yml
vendored
@@ -102,9 +102,9 @@ jobs:
|
||||
echo "### 🎮 Deployment Status" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
# Use canonical domain format (these are the Knative domains)
|
||||
DEV_URL="https://${{ secrets.DEV_DOMAIN }}"
|
||||
STAGING_URL="https://${{ secrets.STAGING_DOMAIN }}"
|
||||
PROD_URL="https://${{ secrets.PROD_DOMAIN }}"
|
||||
DEV_URL="https://${{ secrets.DEV_CANONICAL_DOMAIN }}"
|
||||
STAGING_URL="https://${{ secrets.STAGING_CANONICAL_DOMAIN }}"
|
||||
PROD_URL="https://${{ secrets.PROD_CANONICAL_DOMAIN }}"
|
||||
|
||||
echo "- **Development**: ✅ Live at $DEV_URL" >> $GITHUB_STEP_SUMMARY
|
||||
echo "- **Staging**: ✅ Live at $STAGING_URL" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
24
.github/workflows/smoke-test.yml
vendored
24
.github/workflows/smoke-test.yml
vendored
@@ -44,15 +44,15 @@ jobs:
|
||||
run: |
|
||||
case "${{ matrix.environment }}" in
|
||||
dev)
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.DEV_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.DEV_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "ENV_NAME=development" >> $GITHUB_ENV
|
||||
;;
|
||||
staging)
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.STAGING_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.STAGING_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "ENV_NAME=staging" >> $GITHUB_ENV
|
||||
;;
|
||||
prod)
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.PROD_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "CANONICAL_DOMAIN=https://${{ secrets.PROD_CANONICAL_DOMAIN }}" >> $GITHUB_ENV
|
||||
echo "ENV_NAME=production" >> $GITHUB_ENV
|
||||
;;
|
||||
esac
|
||||
@@ -157,9 +157,9 @@ jobs:
|
||||
|
||||
# Canonical domains (Knative domains only)
|
||||
canonical_domains=(
|
||||
"${{ secrets.DEV_DOMAIN }}"
|
||||
"${{ secrets.STAGING_DOMAIN }}"
|
||||
"${{ secrets.PROD_DOMAIN }}"
|
||||
"${{ secrets.DEV_CANONICAL_DOMAIN }}"
|
||||
"${{ secrets.STAGING_CANONICAL_DOMAIN }}"
|
||||
"${{ secrets.PROD_CANONICAL_DOMAIN }}"
|
||||
)
|
||||
|
||||
for domain in "${canonical_domains[@]}"; do
|
||||
@@ -179,9 +179,9 @@ jobs:
|
||||
|
||||
# Canonical domains (Knative domains only)
|
||||
canonical_domains=(
|
||||
"${{ secrets.DEV_DOMAIN }}"
|
||||
"${{ secrets.STAGING_DOMAIN }}"
|
||||
"${{ secrets.PROD_DOMAIN }}"
|
||||
"${{ secrets.DEV_CANONICAL_DOMAIN }}"
|
||||
"${{ secrets.STAGING_CANONICAL_DOMAIN }}"
|
||||
"${{ secrets.PROD_CANONICAL_DOMAIN }}"
|
||||
)
|
||||
|
||||
for domain in "${canonical_domains[@]}"; do
|
||||
@@ -231,9 +231,9 @@ jobs:
|
||||
echo "### Tested Canonical Domains" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
# Use canonical domain format
|
||||
DEV_URL="https://${{ secrets.DEV_DOMAIN }}"
|
||||
STAGING_URL="https://${{ secrets.STAGING_DOMAIN }}"
|
||||
PROD_URL="https://${{ secrets.PROD_DOMAIN }}"
|
||||
DEV_URL="https://${{ secrets.DEV_CANONICAL_DOMAIN }}"
|
||||
STAGING_URL="https://${{ secrets.STAGING_CANONICAL_DOMAIN }}"
|
||||
PROD_URL="https://${{ secrets.PROD_CANONICAL_DOMAIN }}"
|
||||
|
||||
echo "- 🧪 Development: $DEV_URL" >> $GITHUB_STEP_SUMMARY
|
||||
echo "- 🎭 Staging: $STAGING_URL" >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
@@ -223,9 +223,9 @@ graph TD
|
||||
| `DEV_WEBHOOK_URL` | Development deployment endpoint | Deploy to Development |
|
||||
| `STAGING_WEBHOOK_URL` | Staging deployment endpoint | Deploy to Staging |
|
||||
| `PROD_WEBHOOK_URL` | Production deployment endpoint | Deploy to Production |
|
||||
| `DEV_DOMAIN` | Development domain suffix | Smoke Tests |
|
||||
| `STAGING_DOMAIN` | Staging domain suffix | Smoke Tests |
|
||||
| `PROD_DOMAIN` | Production domain suffix | Smoke Tests |
|
||||
| `DEV_CANONICAL_DOMAIN` | Development canonical domain | Smoke Tests |
|
||||
| `STAGING_CANONICAL_DOMAIN` | Staging canonical domain | Smoke Tests |
|
||||
| `PROD_CANONICAL_DOMAIN` | Production canonical domain | Smoke Tests |
|
||||
|
||||
### Environment URLs
|
||||
|
||||
|
||||
Reference in New Issue
Block a user