fix(backups): change severity and only check report_plans if plans exists (#2291)

Co-authored-by: Pepe Fagoaga <pepe@verica.io>

tests/providers/aws/services/backup/backup_plans_exist/backup_plans_exist_test.py

@@ -26,7 +26,7 @@ class Test_backup_plans_exist:
             assert len(result) == 1
             assert result[0].status == "FAIL"
             assert result[0].status_extended == "No Backup Plan Exist"
-            assert result[0].resource_id == "No Backups"
+            assert result[0].resource_id == "Backups"
             assert result[0].resource_arn == ""
             assert result[0].region == AWS_REGION
 

tests/providers/aws/services/backup/backup_reportplans_exist/backup_reportplans_exist_test.py

@@ -1,15 +1,47 @@
 from datetime import datetime
 from unittest import mock
 
-from prowler.providers.aws.services.backup.backup_service import BackupReportPlan
+from prowler.providers.aws.services.backup.backup_service import (
+    BackupPlan,
+    BackupReportPlan,
+)
 
 AWS_REGION = "eu-west-1"
 
 
 class Test_backup_reportplans_exist:
+    def test_no_backup_plans(self):
+        backup_client = mock.MagicMock
+        backup_client.region = AWS_REGION
+        backup_client.backup_plans = []
+        with mock.patch(
+            "prowler.providers.aws.services.backup.backup_service.Backup",
+            new=backup_client,
+        ):
+            # Test Check
+            from prowler.providers.aws.services.backup.backup_reportplans_exist.backup_reportplans_exist import (
+                backup_reportplans_exist,
+            )
+
+            check = backup_reportplans_exist()
+            result = check.execute()
+
+            assert len(result) == 0
+
     def test_no_backup_report_plans(self):
         backup_client = mock.MagicMock
         backup_client.region = AWS_REGION
+        backup_client.backup_plans = [
+            BackupPlan(
+                arn="ARN",
+                id="MyBackupPlan",
+                region=AWS_REGION,
+                name="MyBackupPlan",
+                version_id="version_id",
+                last_execution_date=datetime(2015, 1, 1),
+                advanced_settings=[],
+            )
+        ]
         backup_client.backup_report_plans = []
         with mock.patch(
             "prowler.providers.aws.services.backup.backup_service.Backup",
@@ -26,13 +58,24 @@ class Test_backup_reportplans_exist:
             assert len(result) == 1
             assert result[0].status == "FAIL"
             assert result[0].status_extended == "No Backup Report Plan Exist"
-            assert result[0].resource_id == "No Backups"
+            assert result[0].resource_id == "Backups"
             assert result[0].resource_arn == ""
             assert result[0].region == AWS_REGION
 
     def test_one_backup_report_plan(self):
         backup_client = mock.MagicMock
         backup_client.region = AWS_REGION
+        backup_client.backup_plans = [
+            BackupPlan(
+                arn="ARN",
+                id="MyBackupPlan",
+                region=AWS_REGION,
+                name="MyBackupPlan",
+                version_id="version_id",
+                last_execution_date=datetime(2015, 1, 1),
+                advanced_settings=[],
+            )
+        ]
         backup_client.backup_report_plans = [
             BackupReportPlan(
                 arn="ARN",

tests/providers/aws/services/backup/backup_vaults_exist/backup_vaults_exist_test.py

@@ -25,7 +25,7 @@ class Test_backup_vaults_exist:
             assert len(result) == 1
             assert result[0].status == "FAIL"
             assert result[0].status_extended == "No Backup Vault Exist"
-            assert result[0].resource_id == "No Backups"
+            assert result[0].resource_id == "Backups"
             assert result[0].resource_arn == ""
             assert result[0].region == AWS_REGION