From 1e3985d3b41dc4cc47c069a4ede5081e3cb44461 Mon Sep 17 00:00:00 2001
From: Ben Allen <ballen@sans.org>
Date: Fri, 7 Jul 2017 16:33:42 -0500
Subject: [PATCH] change name of temp file so that it's random

Allows multiple instances of prowler to run in parallel (eg. via xargs
-P ).
Also, add trap handler to remove temp file if interrupted.
---
 prowler | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/prowler b/prowler
index d623447b..8ea33149 100755
--- a/prowler
+++ b/prowler
@@ -362,7 +362,7 @@ genCredReport() {
 
 # Save report to a file, decode it, deletion at finish and after every single check, acb stands for AWS CIS Benchmark
 saveReport(){
-  TEMP_REPORT_FILE=/tmp/.acb
+  TEMP_REPORT_FILE=$(mktemp -t prowler-XXXXX.cred_report )
   $AWSCLI iam get-credential-report --query 'Content' --output text --profile $PROFILE --region $REGION | decode_report > $TEMP_REPORT_FILE
 }
 
@@ -371,6 +371,9 @@ cleanTemp(){
   rm -fr $TEMP_REPORT_FILE
 }
 
+# Delete the temporary report file if we get interrupted/terminated
+trap cleanTemp SIGHUP SIGINT SIGTERM
+
 # Get a list of all available AWS Regions
 REGIONS=$($AWSCLI ec2 describe-regions --query 'Regions[].RegionName' \
   --output text \