From cea02668adea0e577678e6fc5c7cad71c4a9ef3b Mon Sep 17 00:00:00 2001 From: Ben Allen Date: Wed, 14 Jun 2017 16:35:22 -0500 Subject: [PATCH 1/2] fixes #45 - define TITLE116 variable --- prowler | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/prowler b/prowler index 35a4fd23..12b4154f 100755 --- a/prowler +++ b/prowler @@ -480,7 +480,7 @@ check115(){ } check116(){ - TITLE115="$BLUE 1.16$NORMAL Ensure IAM policies are attached only to groups or roles (Scored)" + TITLE116="$BLUE 1.16$NORMAL Ensure IAM policies are attached only to groups or roles (Scored)" echo -e "\n$TITLE116" LIST_USERS=$($AWSCLI iam list-users --query 'Users[*].UserName' --output text --profile $PROFILE --region $REGION) echo -e " Users with policy attached to them instead to groups: (it may take few seconds...) " @@ -763,7 +763,7 @@ check28(){ CHECK_KMS_KEY_ROTATION=$($AWSCLI kms get-key-rotation-status --key-id $key --profile $PROFILE --region $regx --output text) CHECK_KMS_DEFAULT_KEY=$($AWSCLI kms describe-key --key-id $key --profile $PROFILE --region $regx --query 'KeyMetadata.Description' | sed -n '/Default master key that protects my /p') if [[ $CHECK_KMS_KEY_ROTATION == "True" ]];then - echo -e " $OK OK! Key $key in Region $regx is set correctly$NORMAL" + echo -e " $OK OK! Key $key in Region $regx is set correctly$NORMAL" elif [[ $CHECK_KMS_KEY_ROTATION == "False" && $CHECK_KMS_DEFAULT_KEY ]];then echo -e " $NOTICE Region $regx key $key is an AWS default master key and cannot be deleted nor modified.$NORMAL" else @@ -775,7 +775,7 @@ check28(){ else echo -e " $NOTICE Region $regx doesn't have encryption keys $NORMAL" fi - done + done } check31(){ From d11a80835f4cface144b14d1d654f24419f4435f Mon Sep 17 00:00:00 2001 From: Ben Allen Date: Wed, 14 Jun 2017 16:43:48 -0500 Subject: [PATCH 2/2] fixes #46 - checks 1.16, 1.17, 1.18 were missing from the default list of checks --- prowler | 3 +++ 1 file changed, 3 insertions(+) diff --git a/prowler b/prowler index 12b4154f..e3c3c543 100755 --- a/prowler +++ b/prowler @@ -1187,6 +1187,9 @@ check112 check113 check114 check115 +check116 +check117 +check118 check119 check120 check121