From 274d02576fac75c067cd1f8b47aa7d85d882f964 Mon Sep 17 00:00:00 2001 From: Toni de la Fuente Date: Mon, 10 Feb 2020 23:31:02 +0100 Subject: [PATCH] Revert "Feature/handle get bucket policy error" --- checks/check_extra764 | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/checks/check_extra764 b/checks/check_extra764 index cc8a3574..6fd2c513 100644 --- a/checks/check_extra764 +++ b/checks/check_extra764 @@ -36,16 +36,11 @@ extra764(){ fi # https://aws.amazon.com/premiumsupport/knowledge-center/s3-bucket-policy-for-config-rule/ - # checking if $TEMP_STP_POLICY_FILE is a valid json before converting it to json with jq - if jq -e . >/dev/null 2>&1 <<< "$TEMP_STP_POLICY_FILE"; then - CHECK_BUCKET_STP_POLICY_PRESENT=$(cat $TEMP_STP_POLICY_FILE | jq --arg arn "arn:aws:s3:::${bucket}" '.Statement[]|select(((.Principal|type == "string") and .Principal == "*") and .Action=="s3:*" and (.Resource|type == "array") and (.Resource|map({(.):0})[]|has($arn)) and (.Resource|map({(.):0})[]|has($arn+"/*")) and .Condition.Bool."aws:SecureTransport" == "false")') - if [[ $CHECK_BUCKET_STP_POLICY_PRESENT ]]; then - textPass "Bucket $bucket has S3 bucket policy to deny requests over insecure transport" - else - textFail "Bucket $bucket allows requests over insecure transport" - fi + CHECK_BUCKET_STP_POLICY_PRESENT=$(cat $TEMP_STP_POLICY_FILE | jq --arg arn "arn:aws:s3:::${bucket}" '.Statement[]|select(((.Principal|type == "string") and .Principal == "*") and .Action=="s3:*" and (.Resource|type == "array") and (.Resource|map({(.):0})[]|has($arn)) and (.Resource|map({(.):0})[]|has($arn+"/*")) and .Condition.Bool."aws:SecureTransport" == "false")') + if [[ $CHECK_BUCKET_STP_POLICY_PRESENT ]]; then + textPass "Bucket $bucket has S3 bucket policy to deny requests over insecure transport" else - textInfo "Unknown Error occurred: $TEMP_STP_POLICY_FILE" + textFail "Bucket $bucket allows requests over insecure transport" fi rm -fr $TEMP_STP_POLICY_FILE