ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(policy_condition_parser): add StringEquals aws:SourceArn condition (#2793)

Browse Source
This commit is contained in:
Nacho Rivera
2023-08-31 11:54:48 +02:00
committed by GitHub
parent 8846ae6664
commit 2891bc0b96
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
prowler/providers/aws/lib/policy_condition_parser/policy_condition_parser.py
View File

@@ -25,6 +25,7 @@ def is_account_only_allowed_in_condition(
"s3:resourceaccount", "s3:resourceaccount",
"aws:principalaccount", "aws:principalaccount",
"aws:resourceaccount", "aws:resourceaccount",
"aws:sourcearn",
], ],
"StringLike": [ "StringLike": [
"aws:sourceaccount", "aws:sourceaccount",

20
tests/providers/aws/lib/policy_condition_parser/policy_condition_parser_test.py
View File

@@ -230,6 +230,26 @@ class Test_policy_condition_parser:
condition_statement, TRUSTED_AWS_ACCOUNT_NUMBER condition_statement, TRUSTED_AWS_ACCOUNT_NUMBER
) )
def test_condition_parser_string_equals_aws_SourceArn_str(self):
condition_statement = {
"StringEquals": {
"aws:SourceArn": f"arn:aws:cloudtrail:*:{TRUSTED_AWS_ACCOUNT_NUMBER}:trail/*"
}
}
assert is_account_only_allowed_in_condition(
condition_statement, TRUSTED_AWS_ACCOUNT_NUMBER
)
def test_condition_parser_string_equals_aws_SourceArn_str_not_valid(self):
condition_statement = {
"StringEquals": {
"aws:SourceArn": f"arn:aws:cloudtrail:*:{NON_TRUSTED_AWS_ACCOUNT_NUMBER}:trail/*"
}
}
assert not is_account_only_allowed_in_condition(
condition_statement, TRUSTED_AWS_ACCOUNT_NUMBER
)
def test_condition_parser_string_like_aws_PrincipalAccount_list(self): def test_condition_parser_string_like_aws_PrincipalAccount_list(self):
condition_statement = { condition_statement = {
"StringLike": {"aws:PrincipalAccount": [TRUSTED_AWS_ACCOUNT_NUMBER]} "StringLike": {"aws:PrincipalAccount": [TRUSTED_AWS_ACCOUNT_NUMBER]}