From 2955975793fe195ee8ac0d673278bf67ec8f67ad Mon Sep 17 00:00:00 2001 From: christiandavilakoobin <46561103+christiandavilakoobin@users.noreply.github.com> Date: Mon, 5 Jun 2023 15:48:34 +0200 Subject: [PATCH] fix(cloudfront): fix DefaultCacheConfigBehaviour enum type(#2430) Co-authored-by: Pepe Fagoaga --- .../aws/services/cloudfront/cloudfront_service.py | 6 ++---- .../aws/services/cloudfront/cloudfront_service_test.py | 7 +++++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/prowler/providers/aws/services/cloudfront/cloudfront_service.py b/prowler/providers/aws/services/cloudfront/cloudfront_service.py index cbd1a18d..8c51a31a 100644 --- a/prowler/providers/aws/services/cloudfront/cloudfront_service.py +++ b/prowler/providers/aws/services/cloudfront/cloudfront_service.py @@ -1,4 +1,3 @@ -from dataclasses import dataclass from enum import Enum from typing import Optional @@ -140,9 +139,8 @@ class GeoRestrictionType(Enum): whitelist = "whitelist" -@dataclass -class DefaultCacheConfigBehaviour: - realtime_log_config_arn: str +class DefaultCacheConfigBehaviour(BaseModel): + realtime_log_config_arn: Optional[str] viewer_protocol_policy: ViewerProtocolPolicy field_level_encryption_id: str diff --git a/tests/providers/aws/services/cloudfront/cloudfront_service_test.py b/tests/providers/aws/services/cloudfront/cloudfront_service_test.py index 8f360339..ff25c0de 100644 --- a/tests/providers/aws/services/cloudfront/cloudfront_service_test.py +++ b/tests/providers/aws/services/cloudfront/cloudfront_service_test.py @@ -6,7 +6,10 @@ from moto import mock_cloudfront from moto.core import DEFAULT_ACCOUNT_ID from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info -from prowler.providers.aws.services.cloudfront.cloudfront_service import CloudFront +from prowler.providers.aws.services.cloudfront.cloudfront_service import ( + CloudFront, + ViewerProtocolPolicy, +) # Mock Test Region AWS_REGION = "eu-west-1" @@ -247,7 +250,7 @@ class Test_CloudFront_Service: cloudfront.distributions[ cloudfront_distribution_id ].default_cache_config.viewer_protocol_policy - == "https-only" + == ViewerProtocolPolicy.https_only ) assert ( cloudfront.distributions[