mirror of
https://github.com/ghndrx/prowler.git
synced 2026-02-10 14:55:00 +00:00
fix(GuardDuty): only execute checks if GuardDuty enabled (#3028)
This commit is contained in:
@@ -6,7 +6,7 @@ class guardduty_centrally_managed(Check):
|
|||||||
def execute(self):
|
def execute(self):
|
||||||
findings = []
|
findings = []
|
||||||
for detector in guardduty_client.detectors:
|
for detector in guardduty_client.detectors:
|
||||||
if detector.id:
|
if detector.id and detector.enabled_in_account:
|
||||||
report = Check_Report_AWS(self.metadata())
|
report = Check_Report_AWS(self.metadata())
|
||||||
report.region = detector.region
|
report.region = detector.region
|
||||||
report.resource_id = detector.id
|
report.resource_id = detector.id
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ class guardduty_no_high_severity_findings(Check):
|
|||||||
def execute(self):
|
def execute(self):
|
||||||
findings = []
|
findings = []
|
||||||
for detector in guardduty_client.detectors:
|
for detector in guardduty_client.detectors:
|
||||||
if detector.id:
|
if detector.id and detector.enabled_in_account:
|
||||||
report = Check_Report_AWS(self.metadata())
|
report = Check_Report_AWS(self.metadata())
|
||||||
report.region = detector.region
|
report.region = detector.region
|
||||||
report.resource_id = detector.id
|
report.resource_id = detector.id
|
||||||
|
|||||||
@@ -62,6 +62,31 @@ class Test_guardduty_centrally_managed:
|
|||||||
assert result[0].region == AWS_REGION
|
assert result[0].region == AWS_REGION
|
||||||
assert result[0].resource_arn == DETECTOR_ARN
|
assert result[0].resource_arn == DETECTOR_ARN
|
||||||
|
|
||||||
|
def test_not_enabled_account_detector(self):
|
||||||
|
guardduty_client = mock.MagicMock
|
||||||
|
guardduty_client.detectors = []
|
||||||
|
guardduty_client.detectors.append(
|
||||||
|
Detector(
|
||||||
|
id=AWS_ACCOUNT_NUMBER,
|
||||||
|
region=AWS_REGION,
|
||||||
|
arn=DETECTOR_ARN,
|
||||||
|
enabled_in_account=False,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
with mock.patch(
|
||||||
|
"prowler.providers.aws.services.guardduty.guardduty_service.GuardDuty",
|
||||||
|
guardduty_client,
|
||||||
|
):
|
||||||
|
# Test Check
|
||||||
|
from prowler.providers.aws.services.guardduty.guardduty_centrally_managed.guardduty_centrally_managed import (
|
||||||
|
guardduty_centrally_managed,
|
||||||
|
)
|
||||||
|
|
||||||
|
check = guardduty_centrally_managed()
|
||||||
|
result = check.execute()
|
||||||
|
assert len(result) == 0
|
||||||
|
|
||||||
def test_detector_centralized_managed(self):
|
def test_detector_centralized_managed(self):
|
||||||
guardduty_client = mock.MagicMock
|
guardduty_client = mock.MagicMock
|
||||||
guardduty_client.detectors = []
|
guardduty_client.detectors = []
|
||||||
|
|||||||
@@ -58,6 +58,29 @@ class Test_guardduty_no_high_severity_findings:
|
|||||||
assert result[0].resource_arn == DETECTOR_ARN
|
assert result[0].resource_arn == DETECTOR_ARN
|
||||||
assert result[0].region == AWS_REGION
|
assert result[0].region == AWS_REGION
|
||||||
|
|
||||||
|
def test_not_enabled_account_detector(self):
|
||||||
|
guardduty_client = mock.MagicMock
|
||||||
|
guardduty_client.detectors = []
|
||||||
|
guardduty_client.detectors.append(
|
||||||
|
Detector(
|
||||||
|
id=AWS_ACCOUNT_NUMBER,
|
||||||
|
arn=DETECTOR_ARN,
|
||||||
|
region=AWS_REGION,
|
||||||
|
enabled_in_account=False,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
with mock.patch(
|
||||||
|
"prowler.providers.aws.services.guardduty.guardduty_service.GuardDuty",
|
||||||
|
guardduty_client,
|
||||||
|
):
|
||||||
|
from prowler.providers.aws.services.guardduty.guardduty_no_high_severity_findings.guardduty_no_high_severity_findings import (
|
||||||
|
guardduty_no_high_severity_findings,
|
||||||
|
)
|
||||||
|
|
||||||
|
check = guardduty_no_high_severity_findings()
|
||||||
|
result = check.execute()
|
||||||
|
assert len(result) == 0
|
||||||
|
|
||||||
def test_high_findings(self):
|
def test_high_findings(self):
|
||||||
guardduty_client = mock.MagicMock
|
guardduty_client = mock.MagicMock
|
||||||
guardduty_client.detectors = []
|
guardduty_client.detectors = []
|
||||||
|
|||||||
Reference in New Issue
Block a user