From 3c2c89670847c400cef935944f7e828cde3528f5 Mon Sep 17 00:00:00 2001
From: Sebastian Nyberg <23510320+senyberg@users.noreply.github.com>
Date: Fri, 9 Jun 2023 13:45:28 +0300
Subject: [PATCH] chore(vpc): add mapPublicIpOnLaunch attribute to VPC subnets
 (#2470)

---
 prowler/providers/aws/services/vpc/vpc_service.py             | 2 ++
 .../networkfirewall_in_all_vpc_test.py                        | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/prowler/providers/aws/services/vpc/vpc_service.py b/prowler/providers/aws/services/vpc/vpc_service.py
index fb41cecd..0f3cd7b8 100644
--- a/prowler/providers/aws/services/vpc/vpc_service.py
+++ b/prowler/providers/aws/services/vpc/vpc_service.py
@@ -294,6 +294,7 @@ class VPC:
                                 public=public,
                                 nat_gateway=nat_gateway,
                                 tags=subnet.get("Tags"),
+                                mapPublicIpOnLaunch=subnet["MapPublicIpOnLaunch"],
                             )
                             self.vpc_subnets[subnet["SubnetId"]] = object
                             # Add it to the VPC object
@@ -319,6 +320,7 @@ class VpcSubnet(BaseModel):
     public: bool
     nat_gateway: bool
     region: str
+    mapPublicIpOnLaunch: bool
     tags: Optional[list] = []
 
 
diff --git a/tests/providers/aws/services/networkfirewall/networkfirewall_in_all_vpc/networkfirewall_in_all_vpc_test.py b/tests/providers/aws/services/networkfirewall/networkfirewall_in_all_vpc/networkfirewall_in_all_vpc_test.py
index 4c641b23..ed4daae4 100644
--- a/tests/providers/aws/services/networkfirewall/networkfirewall_in_all_vpc/networkfirewall_in_all_vpc_test.py
+++ b/tests/providers/aws/services/networkfirewall/networkfirewall_in_all_vpc/networkfirewall_in_all_vpc_test.py
@@ -108,6 +108,7 @@ class Test_networkfirewall_in_all_vpc:
                         nat_gateway=False,
                         region=AWS_REGION,
                         tags=[],
+                        mapPublicIpOnLaunch=False,
                     )
                 ],
                 tags=[],
@@ -171,6 +172,7 @@ class Test_networkfirewall_in_all_vpc:
                         nat_gateway=False,
                         region=AWS_REGION,
                         tags=[],
+                        mapPublicIpOnLaunch=False,
                     )
                 ],
                 tags=[],
@@ -244,6 +246,7 @@ class Test_networkfirewall_in_all_vpc:
                         nat_gateway=False,
                         region=AWS_REGION,
                         tags=[],
+                        mapPublicIpOnLaunch=False,
                     )
                 ],
                 tags=[],
@@ -265,6 +268,7 @@ class Test_networkfirewall_in_all_vpc:
                         nat_gateway=False,
                         region=AWS_REGION,
                         tags=[],
+                        mapPublicIpOnLaunch=False,
                     )
                 ],
                 tags=[],