refactor(azure): Change class names from azure services and fix typing error (#3350)

This commit is contained in:
Pedro Martín
2024-02-05 15:43:04 +01:00
committed by GitHub
parent 8c51094df1
commit 4587a9f651
44 changed files with 581 additions and 584 deletions

View File

@@ -7,18 +7,18 @@ from azure.mgmt.sql.models import (
)
from prowler.providers.azure.services.sqlserver.sqlserver_service import (
DatabaseServer,
SQL_Server,
Database,
Server,
SQLServer,
)
from tests.providers.azure.azure_fixtures import (
AZURE_SUSCRIPTION,
AZURE_SUBSCRIPTION,
set_mocked_azure_audit_info,
)
def mock_sqlserver_get_sql_servers(_):
database = DatabaseServer(
database = Database(
id="id",
name="name",
type="type",
@@ -27,8 +27,8 @@ def mock_sqlserver_get_sql_servers(_):
tde_encryption=TransparentDataEncryption(status="Disabled"),
)
return {
AZURE_SUSCRIPTION: [
SQL_Server(
AZURE_SUBSCRIPTION: [
Server(
id="id",
name="name",
public_network_access="public_network_access",
@@ -56,12 +56,12 @@ class Test_SqlServer_Service:
def test__get_client__(self):
sql_server = SQLServer(set_mocked_azure_audit_info())
assert (
sql_server.clients[AZURE_SUSCRIPTION].__class__.__name__
sql_server.clients[AZURE_SUBSCRIPTION].__class__.__name__
== "SqlManagementClient"
)
def test__get_sql_servers__(self):
database = DatabaseServer(
database = Database(
id="id",
name="name",
type="type",
@@ -71,31 +71,30 @@ class Test_SqlServer_Service:
)
sql_server = SQLServer(set_mocked_azure_audit_info())
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].__class__.__name__
== "SQL_Server"
sql_server.sql_servers[AZURE_SUBSCRIPTION][0].__class__.__name__ == "Server"
)
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].id == "id"
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].name == "name"
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].id == "id"
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].name == "name"
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].public_network_access
sql_server.sql_servers[AZURE_SUBSCRIPTION][0].public_network_access
== "public_network_access"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].minimal_tls_version
sql_server.sql_servers[AZURE_SUBSCRIPTION][0].minimal_tls_version
== "minimal_tls_version"
)
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].administrators is None
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].auditing_policies is None
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].firewall_rules is None
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].administrators is None
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].auditing_policies is None
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].firewall_rules is None
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].encryption_protector.__class__.__name__
== "EncryptionProtector"
)
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases == [database]
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases == [database]
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].vulnerability_assessment.__class__.__name__
== "ServerVulnerabilityAssessment"
@@ -104,22 +103,24 @@ class Test_SqlServer_Service:
def test__get_databases__(self):
sql_server = SQLServer(set_mocked_azure_audit_info())
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].__class__.__name__
== "DatabaseServer"
sql_server.sql_servers[AZURE_SUBSCRIPTION][0]
.databases[0]
.__class__.__name__
== "Database"
)
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].id == "id"
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].name == "name"
assert sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].type == "type"
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases[0].id == "id"
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases[0].name == "name"
assert sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases[0].type == "type"
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].location
sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases[0].location
== "location"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0].databases[0].managed_by
sql_server.sql_servers[AZURE_SUBSCRIPTION][0].databases[0].managed_by
== "managed_by"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0]
sql_server.sql_servers[AZURE_SUBSCRIPTION][0]
.databases[0]
.tde_encryption.__class__.__name__
== "TransparentDataEncryption"
@@ -128,13 +129,13 @@ class Test_SqlServer_Service:
def test__get_transparent_data_encryption__(self):
sql_server = SQLServer(set_mocked_azure_audit_info())
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0]
sql_server.sql_servers[AZURE_SUBSCRIPTION][0]
.databases[0]
.tde_encryption.__class__.__name__
== "TransparentDataEncryption"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][0]
sql_server.sql_servers[AZURE_SUBSCRIPTION][0]
.databases[0]
.tde_encryption.status
== "Disabled"
@@ -143,13 +144,13 @@ class Test_SqlServer_Service:
def test__get_encryption_protectors__(self):
sql_server = SQLServer(set_mocked_azure_audit_info())
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].encryption_protector.__class__.__name__
== "EncryptionProtector"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].encryption_protector.server_key_type
== "AzureKeyVault"
@@ -164,13 +165,13 @@ class Test_SqlServer_Service:
sql_server = SQLServer(set_mocked_azure_audit_info())
storage_container_path = "/subcription_id/resource_group/sql_server"
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].vulnerability_assessment.__class__.__name__
== "ServerVulnerabilityAssessment"
)
assert (
sql_server.sql_servers[AZURE_SUSCRIPTION][
sql_server.sql_servers[AZURE_SUBSCRIPTION][
0
].vulnerability_assessment.storage_container_path
== storage_container_path