From 7982cc462adca3649de6e1a75344b55afc90a8d5 Mon Sep 17 00:00:00 2001 From: Huang Yaming Date: Thu, 2 Apr 2020 14:15:02 +0800 Subject: [PATCH] Remove --output text in CLOUDTRAILBUCKET_LOGENABLED When adding `--output text`, aws cli will return `None` instead of `null`. It makes the following if check misjudge LoggingEnabled status. --- checks/check26 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/check26 b/checks/check26 index 83395527..c05a9214 100644 --- a/checks/check26 +++ b/checks/check26 @@ -27,7 +27,7 @@ check26(){ if [[ $CLOUDTRAILBUCKET ]]; then bucket=$CLOUDTRAILBUCKET if [ "$CLOUDTRAIL_ACCOUNT_ID" == "$ACCOUNT_NUM" ]; then - CLOUDTRAILBUCKET_LOGENABLED=$($AWSCLI s3api get-bucket-logging --bucket $bucket $PROFILE_OPT --region $REGION --query 'LoggingEnabled.TargetBucket' --output text 2>&1) + CLOUDTRAILBUCKET_LOGENABLED=$($AWSCLI s3api get-bucket-logging --bucket $bucket $PROFILE_OPT --region $REGION --query 'LoggingEnabled.TargetBucket' 2>&1) if [[ $(echo "$CLOUDTRAILBUCKET_LOGENABLED" | grep AccessDenied) ]]; then textFail "Access Denied Trying to Get Bucket Logging for $bucket" continue