fix(version): handle request response property (#2175)

Co-authored-by: Pepe Fagoaga <pepe@verica.io>

prowler/config/config.py

@@ -1,4 +1,3 @@
-import json
 import os
 import pathlib
 from datetime import datetime, timezone
@@ -52,12 +51,13 @@ def check_current_version(prowler_version):
         release_response = requests.get(
             "https://api.github.com/repos/prowler-cloud/prowler/tags"
         )
-        latest_version = json.loads(release_response)[0]["name"]
+        latest_version = release_response.json()[0]["name"]
         if latest_version != prowler_version:
             return f"(latest is {latest_version}, upgrade for the latest features)"
         else:
             return "(it is the latest version, yay!)"
-    except Exception:
+    except Exception as e:
+        print(e)
         return ""
 
 

tests/config/config_test.py

@@ -1,5 +1,7 @@
 from unittest import mock
 
+from requests import Response
+
 from prowler.config.config import check_current_version
 from prowler.providers.aws.aws_provider import get_aws_available_regions
 
@@ -8,7 +10,9 @@ MOCK_PROWLER_VERSION = "3.3.0"
 
 def mock_prowler_get_latest_release(_):
     """Mock requests.get() to get the Prowler latest release"""
-    return b'[{"name": "3.3.0"}]'
+    response = Response()
+    response._content = b'[{"name":"3.3.0"}]'
+    return response
 
 
 class Test_Config: