diff --git a/Pipfile b/Pipfile index fbd6dce0..ae5a1ba9 100644 --- a/Pipfile +++ b/Pipfile @@ -7,7 +7,7 @@ verify_ssl = true [packages] boto3 = ">=1.9.188" -detect-secrets = ">=0.12.4" +detect-secrets = "==1.0.3" [requires] python_version = "3.7" diff --git a/README.md b/README.md index 51cbfcee..7aa601d9 100644 --- a/README.md +++ b/README.md @@ -79,10 +79,15 @@ Prowler has been written in bash using AWS-CLI and it works in Linux and OSX. - Make sure the latest version of AWS-CLI is installed on your workstation (it works with either v1 or v2), and other components needed, with Python pip already installed: ```sh - pip install awscli detect-secrets + pip install awscli ``` - AWS-CLI can be also installed it using "brew", "apt", "yum" or manually from , but `detect-secrets` has to be installed using `pip`. You will need to install `jq` to get the most from Prowler. + > NOTE: detect-secrets Yelp version is no longer supported the one from IBM is mantained now. Use the one mentioned below or the specific Yelp version 1.0.3 to make sure it works as expected (`pip install detect-secrets==1.0.3`): + ```sh + pip install "git+https://github.com/ibm/detect-secrets.git@master#egg=detect-secrets" + ``` + + AWS-CLI can be also installed it using "brew", "apt", "yum" or manually from , but `detect-secrets` has to be installed using `pip` or `pip3`. You will need to install `jq` to get the most from Prowler. - Make sure jq is installed (example below with "apt" but use a valid package manager for your OS): diff --git a/util/Dockerfile b/util/Dockerfile index 6fbed17c..9467cd0c 100644 --- a/util/Dockerfile +++ b/util/Dockerfile @@ -5,9 +5,9 @@ ARG USERID=34000 RUN addgroup -g ${USERID} ${USERNAME} && \ adduser -s /bin/sh -G ${USERNAME} -D -u ${USERID} ${USERNAME} && \ - apk --update --no-cache add python3 bash curl jq file coreutils py3-pip && \ + apk --update --no-cache add python3 bash curl jq file coreutils py3-pip git && \ pip3 install --upgrade pip && \ - pip3 install awscli boto3 detect-secrets + pip3 install awscli boto3 detect-secrets==1.0.3 WORKDIR /prowler