ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 06:45:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(gcp): remove Default Project ID requirement (#3459)

Browse Source
This commit is contained in:
Sergio Garcia
2024-02-28 13:15:16 +01:00
committed by GitHub
parent 12381aeee0
commit 63c1d1b5d8
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
prowler/providers/common/audit_info.py
View File

@@ -44,15 +44,7 @@ class Audit_Info:
def print_gcp_credentials(self, audit_info: GCP_Audit_Info): def print_gcp_credentials(self, audit_info: GCP_Audit_Info):
# Beautify audited profile, set "default" if there is no profile set # Beautify audited profile, set "default" if there is no profile set
try: profile = getattr(audit_info.credentials, "_service_account_email", "default")
getattr(audit_info.credentials, "_service_account_email")
profile = (
audit_info.credentials._service_account_email
if audit_info.credentials._service_account_email is not None
else "default"
)
except AttributeError:
profile = "default"
report = f""" report = f"""
This report is being generated using credentials below: This report is being generated using credentials below:

7
prowler/providers/gcp/gcp_provider.py
View File

@@ -18,9 +18,6 @@ class GCP_Provider:
self.credentials, self.default_project_id = self.__set_credentials__( self.credentials, self.default_project_id = self.__set_credentials__(
credentials_file credentials_file
) )
if not self.default_project_id:
logger.critical("No Project ID associated to Google Credentials.")
sys.exit(1)
self.project_ids = [] self.project_ids = []
accessible_projects = self.get_project_ids() accessible_projects = self.get_project_ids()
@@ -41,6 +38,10 @@ class GCP_Provider:
# If not projects were input, all accessible projects are scanned by default # If not projects were input, all accessible projects are scanned by default
self.project_ids = accessible_projects self.project_ids = accessible_projects
# Set Default Project ID if not set in credentials
if not self.default_project_id:
self.default_project_id = self.project_ids[0]
def __set_credentials__(self, credentials_file): def __set_credentials__(self, credentials_file):
try: try:
if credentials_file: if credentials_file: