From 654b4702d0bf9ee70ef449003d87e00049fa30ba Mon Sep 17 00:00:00 2001 From: Sergio Garcia <38561120+sergargar@users.noreply.github.com> Date: Tue, 17 Jan 2023 12:17:15 +0100 Subject: [PATCH] fix(error): ecr_repositories_scan_vulnerabilities_in_latest_image report not found (#1719) Co-authored-by: sergargar --- ...es_scan_vulnerabilities_in_latest_image.py | 2 +- ...an_vulnerabilities_in_latest_image_test.py | 26 +++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/prowler/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image.py b/prowler/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image.py index 47e1fe7b..8cea6b04 100644 --- a/prowler/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image.py +++ b/prowler/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image.py @@ -30,6 +30,6 @@ class ecr_repositories_scan_vulnerabilities_in_latest_image(Check): report.status = "FAIL" report.status_extended = f"ECR repository {repository.name} has imageTag {image.latest_tag} scanned with findings: CRITICAL->{image.scan_findings_severity_count.critical}, HIGH->{image.scan_findings_severity_count.high}, MEDIUM->{image.scan_findings_severity_count.medium} " - findings.append(report) + findings.append(report) return findings diff --git a/tests/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image_test.py b/tests/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image_test.py index 2df47e01..bfe3f88e 100644 --- a/tests/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image_test.py +++ b/tests/providers/aws/services/ecr/ecr_repositories_scan_vulnerabilities_in_latest_image/ecr_repositories_scan_vulnerabilities_in_latest_image_test.py @@ -28,6 +28,32 @@ repo_policy_public = { class Test_ecr_repositories_scan_vulnerabilities_in_latest_image: + def test_empty_repository(self): + ecr_client = mock.MagicMock + ecr_client.repositories = [] + ecr_client.repositories.append( + Repository( + name=repository_name, + arn=repository_arn, + region=AWS_REGION, + scan_on_push=True, + policy=repo_policy_public, + images_details=[], + lyfecicle_policy=None, + ) + ) + with mock.patch( + "prowler.providers.aws.services.ecr.ecr_service.ECR", + ecr_client, + ): + from prowler.providers.aws.services.ecr.ecr_repositories_scan_vulnerabilities_in_latest_image.ecr_repositories_scan_vulnerabilities_in_latest_image import ( + ecr_repositories_scan_vulnerabilities_in_latest_image, + ) + + check = ecr_repositories_scan_vulnerabilities_in_latest_image() + result = check.execute() + assert len(result) == 0 + def test_image_scaned_without_findings(self): ecr_client = mock.MagicMock ecr_client.repositories = []