From 6f02606fb7183d6041cd946275d0d4c2ec8d9c30 Mon Sep 17 00:00:00 2001 From: Sergio Garcia <38561120+sergargar@users.noreply.github.com> Date: Mon, 10 Apr 2023 12:06:08 +0200 Subject: [PATCH] fix(iam): handle no display name error in service account (#2176) --- .../iam_sa_no_administrative_privileges.py | 2 +- .../iam_sa_no_user_managed_keys/iam_sa_no_user_managed_keys.py | 2 +- prowler/providers/gcp/services/iam/iam_service.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/prowler/providers/gcp/services/iam/iam_sa_no_administrative_privileges/iam_sa_no_administrative_privileges.py b/prowler/providers/gcp/services/iam/iam_sa_no_administrative_privileges/iam_sa_no_administrative_privileges.py index 632688ea..b1d93adc 100644 --- a/prowler/providers/gcp/services/iam/iam_sa_no_administrative_privileges/iam_sa_no_administrative_privileges.py +++ b/prowler/providers/gcp/services/iam/iam_sa_no_administrative_privileges/iam_sa_no_administrative_privileges.py @@ -12,7 +12,7 @@ class iam_sa_no_administrative_privileges(Check): report = Check_Report_GCP(self.metadata()) report.project_id = iam_client.project_id report.resource_id = account.email - report.resource_name = account.display_name + report.resource_name = account.name report.location = iam_client.region report.status = "PASS" report.status_extended = ( diff --git a/prowler/providers/gcp/services/iam/iam_sa_no_user_managed_keys/iam_sa_no_user_managed_keys.py b/prowler/providers/gcp/services/iam/iam_sa_no_user_managed_keys/iam_sa_no_user_managed_keys.py index 81bd73c9..0a98bfd6 100644 --- a/prowler/providers/gcp/services/iam/iam_sa_no_user_managed_keys/iam_sa_no_user_managed_keys.py +++ b/prowler/providers/gcp/services/iam/iam_sa_no_user_managed_keys/iam_sa_no_user_managed_keys.py @@ -9,7 +9,7 @@ class iam_sa_no_user_managed_keys(Check): report = Check_Report_GCP(self.metadata()) report.project_id = iam_client.project_id report.resource_id = account.email - report.resource_name = account.display_name + report.resource_name = account.name report.location = iam_client.region report.status = "PASS" report.status_extended = ( diff --git a/prowler/providers/gcp/services/iam/iam_service.py b/prowler/providers/gcp/services/iam/iam_service.py index c5d12d37..163916d1 100644 --- a/prowler/providers/gcp/services/iam/iam_service.py +++ b/prowler/providers/gcp/services/iam/iam_service.py @@ -36,7 +36,7 @@ class IAM: ServiceAccount( name=account["name"], email=account["email"], - display_name=account["displayName"], + display_name=account.get("displayName", ""), ) )