From 6f0d42a881cf510d94968544f348b3884b5d38e1 Mon Sep 17 00:00:00 2001 From: Pepe Fagoaga Date: Wed, 3 Aug 2022 12:14:23 +0200 Subject: [PATCH] fix: Sort checks (#1302) * fix: sort checks * fix(metadata): Include missing provider --- ...oup_allow_ingress_from_internet_to_any_port.metadata.json | 1 + prowler | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/providers/aws/services/ec2/ec2_securitygroup_allow_ingress_from_internet_to_any_port/ec2_securitygroup_allow_ingress_from_internet_to_any_port.metadata.json b/providers/aws/services/ec2/ec2_securitygroup_allow_ingress_from_internet_to_any_port/ec2_securitygroup_allow_ingress_from_internet_to_any_port.metadata.json index 940bfb6e..e1dee8ac 100644 --- a/providers/aws/services/ec2/ec2_securitygroup_allow_ingress_from_internet_to_any_port/ec2_securitygroup_allow_ingress_from_internet_to_any_port.metadata.json +++ b/providers/aws/services/ec2/ec2_securitygroup_allow_ingress_from_internet_to_any_port/ec2_securitygroup_allow_ingress_from_internet_to_any_port.metadata.json @@ -1,4 +1,5 @@ { + "Provider": "aws", "CheckID": "ec2_securitygroup_allow_ingress_from_internet_to_any_port", "CheckTitle": "Ensure no security groups allow ingress from 0.0.0.0/0 or ::/0 to any port.", "CheckType": "Infrastructure Security", diff --git a/prowler b/prowler index 4a4e4593..7c9e89ad 100755 --- a/prowler +++ b/prowler @@ -236,6 +236,9 @@ if __name__ == "__main__": checks_to_execute, excluded_services, provider ) + # Sort final check list + checks_to_execute = sorted(checks_to_execute) + # If -l/--list-checks passed as argument, print checks to execute and quit if args.list_checks: print_checks(provider, checks_to_execute, bulk_checks_metadata) @@ -265,7 +268,7 @@ if __name__ == "__main__": # Execute checks if len(checks_to_execute): - for check_name in sorted(checks_to_execute): + for check_name in checks_to_execute: # Recover service from check name service = check_name.split("_")[0] try: