ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 06:45:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(inspector2): Report must have status field (#3419)

Browse Source
This commit is contained in:
Pepe Fagoaga
2024-02-20 12:58:03 +01:00
committed by GitHub
parent bdf3236350
commit 753f32b4cb
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
prowler/providers/aws/services/inspector2/inspector2_active_findings_exist/inspector2_active_findings_exist.py
View File

@@ -8,11 +8,11 @@ class inspector2_active_findings_exist(Check):
def execute(self): def execute(self):
findings = [] findings = []
for inspector in inspector2_client.inspectors: for inspector in inspector2_client.inspectors:
report = Check_Report_AWS(self.metadata())
report.resource_id = inspector.id
report.resource_arn = inspector.arn
report.region = inspector.region
if inspector.status == "ENABLED": if inspector.status == "ENABLED":
report = Check_Report_AWS(self.metadata())
report.resource_id = inspector.id
report.resource_arn = inspector.arn
report.region = inspector.region
active_findings = 0 active_findings = 0
report.status = "PASS" report.status = "PASS"
report.status_extended = "Inspector2 is enabled with no findings." report.status_extended = "Inspector2 is enabled with no findings."
@@ -26,7 +26,7 @@ class inspector2_active_findings_exist(Check):
if active_findings > 0: if active_findings > 0:
report.status = "FAIL" report.status = "FAIL"
report.status_extended = ( report.status_extended = (
f"There are {active_findings} ACTIVE Inspector2 findings." f"There are {active_findings} active Inspector2 findings."
) )
findings.append(report) findings.append(report)

3
prowler/providers/aws/services/inspector2/inspector2_is_enabled/inspector2_is_enabled.py
View File

@@ -18,6 +18,7 @@ class inspector2_is_enabled(Check):
if inspector.status == "ENABLED": if inspector.status == "ENABLED":
report.status = "PASS" report.status = "PASS"
report.status_extended = "Inspector2 is enabled." report.status_extended = "Inspector2 is enabled."
findings.append(report)
else: else:
if inspector2_client.audit_info.ignore_unused_services: if inspector2_client.audit_info.ignore_unused_services:
funtions_in_region = False funtions_in_region = False
@@ -35,6 +36,6 @@ class inspector2_is_enabled(Check):
): ):
report.status = "FAIL" report.status = "FAIL"
report.status_extended = "Inspector2 is not enabled." report.status_extended = "Inspector2 is not enabled."
findings.append(report) findings.append(report)
return findings return findings

4
tests/providers/aws/services/inspector2/inspector2_active_findings_exist/inspector2_active_findings_exist_test.py
View File

@@ -176,7 +176,7 @@ class Test_inspector2_active_findings_exist:
assert result[0].status == "FAIL" assert result[0].status == "FAIL"
assert ( assert (
result[0].status_extended result[0].status_extended
== "There are 1 ACTIVE Inspector2 findings." == "There are 1 active Inspector2 findings."
) )
assert result[0].resource_id == AWS_ACCOUNT_NUMBER assert result[0].resource_id == AWS_ACCOUNT_NUMBER
assert ( assert (
@@ -242,7 +242,7 @@ class Test_inspector2_active_findings_exist:
assert result[0].status == "FAIL" assert result[0].status == "FAIL"
assert ( assert (
result[0].status_extended result[0].status_extended
== "There are 1 ACTIVE Inspector2 findings." == "There are 1 active Inspector2 findings."
) )
assert result[0].resource_id == AWS_ACCOUNT_NUMBER assert result[0].resource_id == AWS_ACCOUNT_NUMBER
assert ( assert (