From a1d26b44c338058b72bcc98da0789fa49c724c06 Mon Sep 17 00:00:00 2001 From: Kasprzykowski Date: Fri, 21 Feb 2020 09:05:33 -0500 Subject: [PATCH 1/2] check_extra999 added and group7_extras updated --- .DS_Store | Bin 0 -> 6148 bytes checks/check_extra999 | 68 ++++++++++++++++++++++++++++++++++++++++++ groups/group7_extras | 2 +- 3 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 .DS_Store create mode 100644 checks/check_extra999 diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..72e2ac53daa48dade914cb862f55591f4abcbff7 GIT binary patch literal 6148 zcmeHK%Sr=55Ukb^0$y_TIKSW@3?Y7jKOiQeU|_|N`=0V$ewx(}khppYcnQ_eT{FF1 zGi)8Uw*lDdu)PD802Xvd96e0UpSw@&sxpoiXS`v*-EVeJ!?2rF|DJH}92>minehjI zju(7jzya^y2lFPG6p#W^Knh3!DR8y|)kzmOXP+RV6p#X!s(^nV8r`uMj*0QzE~o%@f34I3_Yfv!oJ}YBge5(wT2n*9*tQq{HH7o>MnlO(+((GvA^d))N(_ zfD|}Y;5xTU@BjDoKj!~al6F!+3S5)|Hd{ZeSA3=Ft&^AYUfbx8bg%iOyKx;9hG@sc jXvf@mJHCygtZTmJ^IkY62A%n!6ZJFTy2zx!e=G0>-Vz&v literal 0 HcmV?d00001 diff --git a/checks/check_extra999 b/checks/check_extra999 new file mode 100644 index 00000000..2b7cf285 --- /dev/null +++ b/checks/check_extra999 @@ -0,0 +1,68 @@ +#!/usr/bin/env bash + +# Prowler - the handy cloud security tool (copyright 2019) by Toni de la Fuente +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy +# of the License at http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +CHECK_ID_extra999="0.00" +CHECK_TITLE_extra999="[extra999] Find secrets in EC2 Auto Scaling Launch Configuration (Not Scored) (Not part of CIS benchmark)" +CHECK_SCORED_extra999="NOT_SCORED" +CHECK_TYPE_extra999="EXTRA" +CHECK_ALTERNATE_check000="extra999" + +extra999(){ + SECRETS_TEMP_FOLDER="$PROWLER_DIR/secrets-$ACCOUNT_NUM" + if [[ ! -d $SECRETS_TEMP_FOLDER ]]; then + # this folder is deleted once this check is finished + mkdir $SECRETS_TEMP_FOLDER + fi + + textInfo "Looking for secrets in EC2 Auto Scaling Launch Configuration across all regions... (max 100 autoscaling_configurations per region use -m to increase it) " + for regx in $REGIONS; do + LIST_OF_EC2_AUTOSCALING=$($AWSCLI autoscaling describe-launch-configurations $PROFILE_OPT --region $regx --query LaunchConfigurations[*].LaunchConfigurationName --output text --max-items $MAXITEMS | grep -v None) + if [[ $LIST_OF_EC2_AUTOSCALING ]];then + for autoscaling_configuration in $LIST_OF_EC2_AUTOSCALING; do + EC2_AUTOSCALING_USERDATA_FILE="$SECRETS_TEMP_FOLDER/extra999-$autoscaling_configuration-userData.decoded" + EC2_AUTOSCALING_USERDATA=$($AWSCLI autoscaling describe-launch-configurations $PROFILE_OPT --launch-configuration-names $autoscaling_configuration --region $regx --query LaunchConfigurations[*].UserData --output text| grep -v ^None | decode_report > $EC2_AUTOSCALING_USERDATA_FILE) + if [ -s $EC2_AUTOSCALING_USERDATA_FILE ];then + FILE_FORMAT_ASCII=$(file -b $EC2_AUTOSCALING_USERDATA_FILE | grep ASCII) + # This finds ftp or http URLs with credentials and common keywords + # FINDINGS=$(egrep -i '[[:alpha:]]*://[[:alnum:]]*:[[:alnum:]]*@.*/|key|secret|token|pass' $EC2_AUTOSCALING_USERDATA_FILE |wc -l|tr -d '\ ') + # New implementation using https://github.com/Yelp/detect-secrets + if [[ $FILE_FORMAT_ASCII ]]; then + FINDINGS=$(secretsDetector file $EC2_AUTOSCALING_USERDATA_FILE) + if [[ $FINDINGS -eq 0 ]]; then + textPass "$regx: No secrets found in $autoscaling_configuration" "$regx" + # delete file if nothing interesting is there + rm -f $EC2_AUTOSCALING_USERDATA_FILE + else + textFail "$regx: Potential secret found in $autoscaling_configuration" "$regx" + # delete file to not leave trace, user must look at the autoscaling_configuration User Data + rm -f $EC2_AUTOSCALING_USERDATA_FILE + fi + else + mv $EC2_AUTOSCALING_USERDATA_FILE $EC2_AUTOSCALING_USERDATA_FILE.gz ; gunzip $EC2_AUTOSCALING_USERDATA_FILE.gz + FINDINGS=$(secretsDetector file $EC2_AUTOSCALING_USERDATA_FILE) + if [[ $FINDINGS -eq 0 ]]; then + textPass "$regx: No secrets found in $autoscaling_configuration User Data" "$regx" + rm -f $EC2_AUTOSCALING_USERDATA_FILE + else + textFail "$regx: Potential secret found in $autoscaling_configuration" "$regx" + fi + fi + else + textPass "$regx: No secrets found in $autoscaling_configuration User Data or it is empty" "$regx" + fi + done + else + textInfo "$regx: No EC2 autoscaling_configurations found" "$regx" + fi + done + rm -rf $SECRETS_TEMP_FOLDER +} diff --git a/groups/group7_extras b/groups/group7_extras index 84280f8e..5e928c3a 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - [extras] **********************************************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra999' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets` From 40985212ab84454766141152d42bf610c08440fd Mon Sep 17 00:00:00 2001 From: Kasprzykowski Date: Fri, 21 Feb 2020 09:24:13 -0500 Subject: [PATCH 2/2] check_extra775 added | group7_extras and group11_secrets updated --- checks/{check_extra999 => check_extra775} | 14 +++++++------- groups/group11_secrets | 2 +- groups/group7_extras | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) rename checks/{check_extra999 => check_extra775} (93%) diff --git a/checks/check_extra999 b/checks/check_extra775 similarity index 93% rename from checks/check_extra999 rename to checks/check_extra775 index 2b7cf285..20da2849 100644 --- a/checks/check_extra999 +++ b/checks/check_extra775 @@ -10,13 +10,13 @@ # under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR # CONDITIONS OF ANY KIND, either express or implied. See the License for the # specific language governing permissions and limitations under the License. -CHECK_ID_extra999="0.00" -CHECK_TITLE_extra999="[extra999] Find secrets in EC2 Auto Scaling Launch Configuration (Not Scored) (Not part of CIS benchmark)" -CHECK_SCORED_extra999="NOT_SCORED" -CHECK_TYPE_extra999="EXTRA" -CHECK_ALTERNATE_check000="extra999" +CHECK_ID_extra775="0.00" +CHECK_TITLE_extra775="[extra775] Find secrets in EC2 Auto Scaling Launch Configuration (Not Scored) (Not part of CIS benchmark)" +CHECK_SCORED_extra775="NOT_SCORED" +CHECK_TYPE_extra775="EXTRA" +CHECK_ALTERNATE_check000="extra775" -extra999(){ +extra775(){ SECRETS_TEMP_FOLDER="$PROWLER_DIR/secrets-$ACCOUNT_NUM" if [[ ! -d $SECRETS_TEMP_FOLDER ]]; then # this folder is deleted once this check is finished @@ -28,7 +28,7 @@ extra999(){ LIST_OF_EC2_AUTOSCALING=$($AWSCLI autoscaling describe-launch-configurations $PROFILE_OPT --region $regx --query LaunchConfigurations[*].LaunchConfigurationName --output text --max-items $MAXITEMS | grep -v None) if [[ $LIST_OF_EC2_AUTOSCALING ]];then for autoscaling_configuration in $LIST_OF_EC2_AUTOSCALING; do - EC2_AUTOSCALING_USERDATA_FILE="$SECRETS_TEMP_FOLDER/extra999-$autoscaling_configuration-userData.decoded" + EC2_AUTOSCALING_USERDATA_FILE="$SECRETS_TEMP_FOLDER/extra775-$autoscaling_configuration-userData.decoded" EC2_AUTOSCALING_USERDATA=$($AWSCLI autoscaling describe-launch-configurations $PROFILE_OPT --launch-configuration-names $autoscaling_configuration --region $regx --query LaunchConfigurations[*].UserData --output text| grep -v ^None | decode_report > $EC2_AUTOSCALING_USERDATA_FILE) if [ -s $EC2_AUTOSCALING_USERDATA_FILE ];then FILE_FORMAT_ASCII=$(file -b $EC2_AUTOSCALING_USERDATA_FILE | grep ASCII) diff --git a/groups/group11_secrets b/groups/group11_secrets index b66a6f88..24ceda0c 100644 --- a/groups/group11_secrets +++ b/groups/group11_secrets @@ -15,7 +15,7 @@ GROUP_ID[11]='secrets' GROUP_NUMBER[11]='11.0' GROUP_TITLE[11]='Look for keys secrets or passwords around resources - [secrets] **' GROUP_RUN_BY_DEFAULT[11]='N' # but it runs when execute_all is called (default) -GROUP_CHECKS[11]='extra741,extra742,extra759,extra760,extra768' +GROUP_CHECKS[11]='extra741,extra742,extra759,extra760,extra768,extra775' # requires https://github.com/Yelp/detect-secrets # `pip install detect-secrets` diff --git a/groups/group7_extras b/groups/group7_extras index 5e928c3a..37aa1d04 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - [extras] **********************************************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra999' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets`