From 7c4d6eb02d7325c308344ed87f310c253f8496b1 Mon Sep 17 00:00:00 2001 From: Sergio Garcia <38561120+sergargar@users.noreply.github.com> Date: Fri, 24 Mar 2023 18:30:33 +0100 Subject: [PATCH] fix(gcp): handle error when Project ID is None (#2130) --- prowler/providers/gcp/gcp_provider.py | 3 +++ tests/providers/common/audit_info_test.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/prowler/providers/gcp/gcp_provider.py b/prowler/providers/gcp/gcp_provider.py index 74b006ef..582552cc 100644 --- a/prowler/providers/gcp/gcp_provider.py +++ b/prowler/providers/gcp/gcp_provider.py @@ -16,6 +16,9 @@ class GCP_Provider: ): logger.info("Instantiating GCP Provider ...") self.credentials, self.project_id = self.__set_credentials__(credentials_file) + if not self.project_id: + logger.critical("No Project ID associated to Google Credentials.") + sys.exit(1) def __set_credentials__(self, credentials_file): try: diff --git a/tests/providers/common/audit_info_test.py b/tests/providers/common/audit_info_test.py index c877cb9e..fc1f52b2 100644 --- a/tests/providers/common/audit_info_test.py +++ b/tests/providers/common/audit_info_test.py @@ -77,7 +77,7 @@ def mock_set_azure_credentials(*_): def mock_set_gcp_credentials(*_): - return (None, None) + return (None, "project") class Test_Set_Audit_Info: