ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a query to get AccountMFAEnabled rather than awk/sed

Browse Source 
Parsing with awk/sed relies on the json being pretty printed (no other values on the same line), which is not always true, causing false-positive warings sometimes. Querying for SummaryMap.AccountMFAEnabled directly should be more robust.
This commit is contained in:
Tomáš Milata
2017-12-12 17:11:56 +00:00
parent 2063a718a5
commit 887805c5be
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
prowler
View File

@@ -684,7 +684,7 @@ check112(){
check113(){ check113(){
ID113="1.13" ID113="1.13"
TITLE113="Ensure MFA is enabled for the root account (Scored)" TITLE113="Ensure MFA is enabled for the root account (Scored)"
COMMAND113=$($AWSCLI iam get-account-summary $PROFILE_OPT --region $REGION --output json|grep AccountMFAEnabled | awk -F': ' '{ print $2 }'|sed 's/,//') COMMAND113=$($AWSCLI iam get-account-summary $PROFILE_OPT --region $REGION --output json --query 'SummaryMap.AccountMFAEnabled')
textTitle "$ID113" "$TITLE113" "SCORED" "LEVEL1" textTitle "$ID113" "$TITLE113" "SCORED" "LEVEL1"
if [ "$COMMAND113" == "1" ]; then if [ "$COMMAND113" == "1" ]; then
textOK "Virtual MFA is enabled for root" textOK "Virtual MFA is enabled for root"