From cea0cfb47d46450bc0638b0f25487260c386bf00 Mon Sep 17 00:00:00 2001 From: bgeesaman Date: Wed, 8 Jan 2020 20:21:18 -0500 Subject: [PATCH 1/3] Prevent colorization on Failed and Info --- include/outputs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/outputs b/include/outputs index a33b1dca..b18ac683 100644 --- a/include/outputs +++ b/include/outputs @@ -76,7 +76,7 @@ textInfo(){ else REPREGION=$REGION fi - jq -c \ + jq -M -c \ --arg PROFILE "$PROFILE" \ --arg ACCOUNT_NUM "$ACCOUNT_NUM" \ --arg TITLE_TEXT "$TITLE_TEXT" \ @@ -119,7 +119,7 @@ textFail(){ else REPREGION=$REGION fi - jq -c \ + jq -M -c \ --arg PROFILE "$PROFILE" \ --arg ACCOUNT_NUM "$ACCOUNT_NUM" \ --arg TITLE_TEXT "$TITLE_TEXT" \ From 4c1d1887e4e0fd85747fdb068ab8682e88715f8b Mon Sep 17 00:00:00 2001 From: root Date: Fri, 10 Jan 2020 15:47:15 -0500 Subject: [PATCH 2/3] Add Prowler check for unused elastic IP addresses --- checks/check_extra772 | 36 ++++++++++++++++++++++++++++++++++++ groups/group7_extras | 2 +- 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 checks/check_extra772 diff --git a/checks/check_extra772 b/checks/check_extra772 new file mode 100644 index 00000000..83f3cdd5 --- /dev/null +++ b/checks/check_extra772 @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Prowler - the handy cloud security tool (copyright 2018) by Toni de la Fuente +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy +# of the License at http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +CHECK_ID_extra772="7.72" +CHECK_TITLE_extra772="[extra772] Check if elastic IPs are unused (Not Scored) (Not part of CIS benchmark)" +CHECK_SCORED_extra772="NOT_SCORED" +CHECK_TYPE_extra772="EXTRA" +CHECK_ALTERNATE_check772="extra772" + +extra772(){ + for region in $REGIONS; do + EIP_DUMP=$($AWSCLI ec2 describe-addresses ${PROFILE_OPT} --region $region) + EIP_LIST=$(echo $EIP_DUMP | jq -r '.Addresses[].AllocationId') + if [[ $EIP_LIST ]]; then + for eip in $EIP_LIST; do + ASSOCIATION_ID=$(echo $EIP_DUMP | jq -r --arg i "$eip" '.Addresses[]|select(.AllocationId==$i)|.AssociationId') + if [[ "$ASSOCIATION_ID" == "null" ]]; then + textFail "$region: EIP $eip is unused" $region + else + textPass "$region: EIP $eip is used" $region + fi + done + else + textInfo "$region: No Elastic IPs found" $region + fi + done +} diff --git a/groups/group7_extras b/groups/group7_extras index 12afb988..b452cecd 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - [extras] **********************************************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra766,extra767,extra768,extra769,extra770,extra771' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra766,extra767,extra768,extra769,extra770,extra771,extra772' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets` From 9fc0f6c61c585684a2eb675f42cc4b24cb85a1d2 Mon Sep 17 00:00:00 2001 From: "C.J" <31103058+zfLQ2qx2@users.noreply.github.com> Date: Sat, 25 Jan 2020 15:29:05 -0500 Subject: [PATCH 3/3] Remove check 766, dupe of check 765 --- checks/check_extra766 | 46 ------------------------------------------- groups/group7_extras | 2 +- 2 files changed, 1 insertion(+), 47 deletions(-) delete mode 100644 checks/check_extra766 diff --git a/checks/check_extra766 b/checks/check_extra766 deleted file mode 100644 index 2382f4ac..00000000 --- a/checks/check_extra766 +++ /dev/null @@ -1,46 +0,0 @@ -#!/usr/bin/env bash - -# Prowler - the handy cloud security tool (copyright 2018) by Toni de la Fuente -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may not -# use this file except in compliance with the License. You may obtain a copy -# of the License at http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR -# CONDITIONS OF ANY KIND, either express or implied. See the License for the -# specific language governing permissions and limitations under the License. - -# Remediation: -# -# https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html#configuring-instance-metadata-service -# -# aws ecr put-image-scanning-configuration \ -# --region \ -# --repository-name \ -# --image-scanning-configuration scanOnPush=true - - -CHECK_ID_extra766="7.66" -CHECK_TITLE_extra766="[extra766] Check if ECR image scan on push is enabled (Not Scored) (Not part of CIS benchmark)" -CHECK_SCORED_extra766="NOT_SCORED" -CHECK_TYPE_extra766="EXTRA" -CHECK_ALTERNATE_check766="extra766" - -extra766(){ - for regx in $REGIONS; do - LIST_ECR_REPOS=$($AWSCLI ecr describe-repositories $PROFILE_OPT --region $regx --query "repositories[*].[repositoryName]" --output text 2>&1) - if [[ $LIST_ECR_REPOS ]]; then - for repo in $LIST_ECR_REPOS; do - SCAN_ENABLED=$($AWSCLI ecr describe-repositories $PROFILE_OPT --region $regx --query "repositories[?repositoryName==\`$repo\`].[imageScanningConfiguration.scanOnPush]" --output text|grep True) - if [[ $SCAN_ENABLED ]];then - textPass "$regx: ECR repository $repo has scan on push enabled" "$regx" - else - textFail "$regx: ECR repository $repo has scan on push disabled!" "$regx" - fi - done - else - textInfo "$regx: No ECR repositories found" "$regx" - fi - done -} diff --git a/groups/group7_extras b/groups/group7_extras index 12afb988..30bd2e77 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - [extras] **********************************************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra766,extra767,extra768,extra769,extra770,extra771' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra737,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra756,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets`