From 8ee06449b70b5d5a393c21f82fc129e7b909d4e9 Mon Sep 17 00:00:00 2001 From: gabrielsoltz Date: Fri, 7 Jun 2019 05:49:47 +0100 Subject: [PATCH] fix code --- checks/check_extra713 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/checks/check_extra713 b/checks/check_extra713 index 6a493804..27eb9add 100644 --- a/checks/check_extra713 +++ b/checks/check_extra713 @@ -21,14 +21,15 @@ extra713(){ # Guardduty Regions are not the same as REGIONS PYTHON=$(which python) if [ ! -z "${PYTHON}" ]; then + #textInfo "Using python and boto3 for getting Guardduty Available Regions" GD_REGIONS=($($PYTHON -c "import boto3 ; session = boto3.session.Session() ; print (session.get_available_regions('guardduty'))")) + for GD_REGION in "${GD_REGIONS[@]}"; do GD_REGIONS_PARSED+="$(echo "$GD_REGION" | cut -d \' -f 2 | cut -d \' -f 1 && echo " ")"; done else - GD_REGIONS=$REGIONS + GD_REGIONS_PARSED=$REGIONS fi # "Check if GuardDuty is enabled (Not Scored) (Not part of CIS benchmark)" - for GD_REGION in "${GD_REGIONS[@]}"; do - regx="$(echo "$GD_REGION" | cut -d \' -f 2 | cut -d \' -f 1)" + for regx in $GD_REGIONS_PARSED; do LIST_OF_GUARDDUTY_DETECTORS=$($AWSCLI guardduty list-detectors $PROFILE_OPT --region $regx --output text 2> /dev/null | cut -f2) if [[ $LIST_OF_GUARDDUTY_DETECTORS ]];then while read -r detector;do