From 9236f5d0582b671aed1eeeb27b340c7fa62b5381 Mon Sep 17 00:00:00 2001 From: Pepe Fagoaga Date: Tue, 5 Dec 2023 10:02:54 +0100 Subject: [PATCH] test(audit_info): refactor autoscaling (#3102) --- ...d_secrets_ec2_launch_configuration_test.py | 76 ++++++------------- .../autoscaling_group_multiple_az_test.py | 64 ++++------------ .../autoscaling/autoscaling_service_test.py | 61 ++++----------- 3 files changed, 53 insertions(+), 148 deletions(-) diff --git a/tests/providers/aws/services/autoscaling/autoscaling_find_secrets_ec2_launch_configuration/autoscaling_find_secrets_ec2_launch_configuration_test.py b/tests/providers/aws/services/autoscaling/autoscaling_find_secrets_ec2_launch_configuration/autoscaling_find_secrets_ec2_launch_configuration_test.py index bb24d250..8b510f03 100644 --- a/tests/providers/aws/services/autoscaling/autoscaling_find_secrets_ec2_launch_configuration/autoscaling_find_secrets_ec2_launch_configuration_test.py +++ b/tests/providers/aws/services/autoscaling/autoscaling_find_secrets_ec2_launch_configuration/autoscaling_find_secrets_ec2_launch_configuration_test.py @@ -2,61 +2,29 @@ from os import path from pathlib import Path from unittest import mock -from boto3 import client, session +from boto3 import client from moto import mock_autoscaling -from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info -from prowler.providers.common.models import Audit_Metadata - -AWS_REGION = "us-east-1" -AWS_ACCOUNT_NUMBER = "123456789012" +from tests.providers.aws.audit_info_utils import ( + AWS_REGION_US_EAST_1, + set_mocked_aws_audit_info, +) ACTUAL_DIRECTORY = Path(path.dirname(path.realpath(__file__))) FIXTURES_DIR_NAME = "fixtures" class Test_autoscaling_find_secrets_ec2_launch_configuration: - def set_mocked_audit_info(self): - audit_info = AWS_Audit_Info( - session_config=None, - original_session=None, - audit_session=session.Session( - profile_name=None, - botocore_session=None, - ), - audited_account=AWS_ACCOUNT_NUMBER, - audited_account_arn=f"arn:aws:iam::{AWS_ACCOUNT_NUMBER}:root", - audited_user_id=None, - audited_partition="aws", - audited_identity_arn=None, - profile=None, - profile_region=None, - credentials=None, - assumed_role_info=None, - audited_regions=["us-east-1", "eu-west-1"], - organizations_metadata=None, - audit_resources=None, - mfa_enabled=False, - audit_metadata=Audit_Metadata( - services_scanned=0, - expected_checks=[], - completed_checks=0, - audit_progress=0, - ), - ) - - return audit_info - @mock_autoscaling def test_no_autoscaling(self): - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.launch_configurations = [] from prowler.providers.aws.services.autoscaling.autoscaling_service import ( AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -79,7 +47,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: def test_one_autoscaling_with_no_secrets(self): # Include launch_configurations to check launch_configuration_name = "tester" - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName=launch_configuration_name, ImageId="ami-12c6146b", @@ -96,7 +64,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -120,13 +88,13 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) assert result[0].resource_id == launch_configuration_name assert result[0].resource_arn == launch_configuration_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 @mock_autoscaling def test_one_autoscaling_with_secrets(self): # Include launch_configurations to check launch_configuration_name = "tester" - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName=launch_configuration_name, ImageId="ami-12c6146b", @@ -143,7 +111,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -167,7 +135,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) assert result[0].resource_id == launch_configuration_name assert result[0].resource_arn == launch_configuration_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 @mock_autoscaling def test_one_autoscaling_file_with_secrets(self): @@ -178,7 +146,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) secrets = f.read() launch_configuration_name = "tester" - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="tester", ImageId="ami-12c6146b", @@ -195,7 +163,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -219,13 +187,13 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) assert result[0].resource_id == launch_configuration_name assert result[0].resource_arn == launch_configuration_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 @mock_autoscaling def test_one_launch_configurations_without_user_data(self): # Include launch_configurations to check launch_configuration_name = "tester" - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName=launch_configuration_name, ImageId="ami-12c6146b", @@ -241,7 +209,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -265,7 +233,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) assert result[0].resource_id == launch_configuration_name assert result[0].resource_arn == launch_configuration_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 @mock_autoscaling def test_one_autoscaling_file_with_secrets_gzip(self): @@ -277,7 +245,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: secrets = f.read() launch_configuration_name = "tester" - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="tester", ImageId="ami-12c6146b", @@ -294,7 +262,7 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -318,4 +286,4 @@ class Test_autoscaling_find_secrets_ec2_launch_configuration: ) assert result[0].resource_id == launch_configuration_name assert result[0].resource_arn == launch_configuration_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 diff --git a/tests/providers/aws/services/autoscaling/autoscaling_group_multiple_az/autoscaling_group_multiple_az_test.py b/tests/providers/aws/services/autoscaling/autoscaling_group_multiple_az/autoscaling_group_multiple_az_test.py index 79d0f992..d2b052ef 100644 --- a/tests/providers/aws/services/autoscaling/autoscaling_group_multiple_az/autoscaling_group_multiple_az_test.py +++ b/tests/providers/aws/services/autoscaling/autoscaling_group_multiple_az/autoscaling_group_multiple_az_test.py @@ -1,57 +1,25 @@ from unittest import mock -from boto3 import client, session +from boto3 import client from moto import mock_autoscaling -from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info -from prowler.providers.common.models import Audit_Metadata - -AWS_REGION = "us-east-1" -AWS_ACCOUNT_NUMBER = "123456789012" +from tests.providers.aws.audit_info_utils import ( + AWS_REGION_US_EAST_1, + set_mocked_aws_audit_info, +) class Test_autoscaling_group_multiple_az: - def set_mocked_audit_info(self): - audit_info = AWS_Audit_Info( - session_config=None, - original_session=None, - audit_session=session.Session( - profile_name=None, - botocore_session=None, - ), - audited_account=AWS_ACCOUNT_NUMBER, - audited_account_arn=f"arn:aws:iam::{AWS_ACCOUNT_NUMBER}:root", - audited_user_id=None, - audited_partition="aws", - audited_identity_arn=None, - profile=None, - profile_region=None, - credentials=None, - assumed_role_info=None, - audited_regions=["us-east-1", "eu-west-1"], - organizations_metadata=None, - audit_resources=None, - mfa_enabled=False, - audit_metadata=Audit_Metadata( - services_scanned=0, - expected_checks=[], - completed_checks=0, - audit_progress=0, - ), - ) - - return audit_info - @mock_autoscaling def test_no_autoscaling(self): - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.groups = [] from prowler.providers.aws.services.autoscaling.autoscaling_service import ( AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -72,7 +40,7 @@ class Test_autoscaling_group_multiple_az: @mock_autoscaling def test_groups_with_multi_az(self): - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="test", ImageId="ami-12c6146b", @@ -98,7 +66,7 @@ class Test_autoscaling_group_multiple_az: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -123,12 +91,12 @@ class Test_autoscaling_group_multiple_az: ) assert result[0].resource_id == autoscaling_group_name assert result[0].resource_arn == autoscaling_group_arn - assert result[0].region == AWS_REGION + assert result[0].region == AWS_REGION_US_EAST_1 assert result[0].resource_tags == [] @mock_autoscaling def test_groups_with_single_az(self): - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="test", ImageId="ami-12c6146b", @@ -154,7 +122,7 @@ class Test_autoscaling_group_multiple_az: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -183,7 +151,7 @@ class Test_autoscaling_group_multiple_az: @mock_autoscaling def test_groups_witd_and_without(self): - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="test", ImageId="ami-12c6146b", @@ -221,7 +189,7 @@ class Test_autoscaling_group_multiple_az: AutoScaling, ) - current_audit_info = self.set_mocked_audit_info() + current_audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", @@ -248,7 +216,7 @@ class Test_autoscaling_group_multiple_az: ) assert check.resource_arn == autoscaling_group_arn_1 assert check.resource_tags == [] - assert check.region == AWS_REGION + assert check.region == AWS_REGION_US_EAST_1 if check.resource_id == autoscaling_group_name_2: assert check.status == "FAIL" assert ( @@ -257,4 +225,4 @@ class Test_autoscaling_group_multiple_az: ) assert check.resource_tags == [] assert check.resource_arn == autoscaling_group_arn_2 - assert check.region == AWS_REGION + assert check.region == AWS_REGION_US_EAST_1 diff --git a/tests/providers/aws/services/autoscaling/autoscaling_service_test.py b/tests/providers/aws/services/autoscaling/autoscaling_service_test.py index 0c6b6080..f2eb5e37 100644 --- a/tests/providers/aws/services/autoscaling/autoscaling_service_test.py +++ b/tests/providers/aws/services/autoscaling/autoscaling_service_test.py @@ -1,53 +1,22 @@ from base64 import b64decode -from boto3 import client, session +from boto3 import client from moto import mock_autoscaling -from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info from prowler.providers.aws.services.autoscaling.autoscaling_service import AutoScaling -from prowler.providers.common.models import Audit_Metadata - -AWS_ACCOUNT_NUMBER = "123456789012" -AWS_REGION = "us-east-1" +from tests.providers.aws.audit_info_utils import ( + AWS_ACCOUNT_NUMBER, + AWS_REGION_US_EAST_1, + set_mocked_aws_audit_info, +) class Test_AutoScaling_Service: - # Mocked Audit Info - def set_mocked_audit_info(self): - audit_info = AWS_Audit_Info( - session_config=None, - original_session=None, - audit_session=session.Session( - profile_name=None, - botocore_session=None, - ), - audited_account=AWS_ACCOUNT_NUMBER, - audited_account_arn=f"arn:aws:iam::{AWS_ACCOUNT_NUMBER}:root", - audited_user_id=None, - audited_partition="aws", - audited_identity_arn=None, - profile=None, - profile_region=None, - credentials=None, - assumed_role_info=None, - audited_regions=None, - organizations_metadata=None, - audit_resources=None, - mfa_enabled=False, - audit_metadata=Audit_Metadata( - services_scanned=0, - expected_checks=[], - completed_checks=0, - audit_progress=0, - ), - ) - return audit_info - # Test AutoScaling Service @mock_autoscaling def test_service(self): # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) assert autoscaling.service == "autoscaling" @@ -55,7 +24,7 @@ class Test_AutoScaling_Service: @mock_autoscaling def test_client(self): # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) for regional_client in autoscaling.regional_clients.values(): assert regional_client.__class__.__name__ == "AutoScaling" @@ -64,7 +33,7 @@ class Test_AutoScaling_Service: @mock_autoscaling def test__get_session__(self): # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) assert autoscaling.session.__class__.__name__ == "Session" @@ -72,7 +41,7 @@ class Test_AutoScaling_Service: @mock_autoscaling def test_audited_account(self): # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) assert autoscaling.audited_account == AWS_ACCOUNT_NUMBER @@ -80,7 +49,7 @@ class Test_AutoScaling_Service: @mock_autoscaling def test__describe_launch_configurations__(self): # Generate AutoScaling Client - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) # Create AutoScaling API autoscaling_client.create_launch_configuration( LaunchConfigurationName="tester1", @@ -98,7 +67,7 @@ class Test_AutoScaling_Service: SecurityGroups=["default", "default2"], ) # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) assert len(autoscaling.launch_configurations) == 2 assert autoscaling.launch_configurations[0].name == "tester1" @@ -114,7 +83,7 @@ class Test_AutoScaling_Service: @mock_autoscaling def test__describe_auto_scaling_groups__(self): # Generate AutoScaling Client - autoscaling_client = client("autoscaling", region_name=AWS_REGION) + autoscaling_client = client("autoscaling", region_name=AWS_REGION_US_EAST_1) autoscaling_client.create_launch_configuration( LaunchConfigurationName="test", ImageId="ami-12c6146b", @@ -138,14 +107,14 @@ class Test_AutoScaling_Service: ) # AutoScaling client for this test class - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_US_EAST_1]) autoscaling = AutoScaling(audit_info) print("asg", asg) assert len(autoscaling.groups) == 1 # create_auto_scaling_group doesn't return the ARN, can't check it # assert autoscaling.groups[0].arn == assert autoscaling.groups[0].name == "my-autoscaling-group" - assert autoscaling.groups[0].region == AWS_REGION + assert autoscaling.groups[0].region == AWS_REGION_US_EAST_1 assert autoscaling.groups[0].availability_zones == ["us-east-1a", "us-east-1b"] assert autoscaling.groups[0].tags == [ {