feat(RDS): Service and missing checks (#1513)

lib/banner.py

@@ -22,10 +22,10 @@ def print_banner(args):
     if args.verbose or args.quiet:
         print(
             f"""
-        Color code for results:
-        - {Fore.YELLOW}INFO (Information){Style.RESET_ALL}
-        - {Fore.GREEN}PASS (Recommended value){Style.RESET_ALL}
-        - {orange_color}WARNING (Ignored by allowlist){Style.RESET_ALL}
-        - {Fore.RED}FAIL (Fix required){Style.RESET_ALL}
-        """
+Color code for results:
+- {Fore.YELLOW}INFO (Information){Style.RESET_ALL}
+- {Fore.GREEN}PASS (Recommended value){Style.RESET_ALL}
+- {orange_color}WARNING (Ignored by allowlist){Style.RESET_ALL}
+- {Fore.RED}FAIL (Fix required){Style.RESET_ALL}
+            """
         )

lib/check/check.py

@@ -271,4 +271,6 @@ def execute_checks(
                 logger.error(
                     f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
                 )
+        bar.title = f"-> {Fore.GREEN}Scan is completed!"
+    print(Style.RESET_ALL)
     return all_findings

lib/outputs/outputs.py

@@ -69,7 +69,6 @@ def report(check_findings, output_options, audit_info):
                 print(
                     f"\t{color}{finding.status}{Style.RESET_ALL} {finding.region}: {finding.status_extended}"
                 )
-
             if file_descriptors:
                 # sending the finding to input options
                 if "csv" in file_descriptors:
@@ -109,7 +108,9 @@ def report(check_findings, output_options, audit_info):
         color = set_report_color("INFO")
         if not output_options.is_quiet and output_options.verbose:
             print(f"\t{color}INFO{Style.RESET_ALL} There are no resources")
-
+    # Separator between findings and bar
+    if output_options.is_quiet or output_options.verbose:
+        print()
     if file_descriptors:
         # Close all file descriptors
         for file_descriptor in file_descriptors:
@@ -263,10 +264,11 @@ def close_json(output_filename, output_directory, mode):
             filename,
             "a",
         )
-        # Replace last comma for square bracket
-        file_descriptor.seek(file_descriptor.tell() - 1, os.SEEK_SET)
-        file_descriptor.truncate()
-        file_descriptor.write("]")
+        # Replace last comma for square bracket if not empty
+        if file_descriptor.tell() > 0:
+            file_descriptor.seek(file_descriptor.tell() - 1, os.SEEK_SET)
+            file_descriptor.truncate()
+            file_descriptor.write("]")
         file_descriptor.close()
     except Exception as error:
         logger.critical(f"{error.__class__.__name__} -- {error}")
@@ -352,7 +354,6 @@ def display_summary_table(
                         current["Low"] += 1
 
             # Add final service
-
             add_service_to_table(findings_table, current)
 
             print("\nOverview Results:")