chore(tests): Replace sure with standard assert (#2738)

2026-02-10 14:55:00 +00:00 · 2023-08-17 11:36:45 +02:00
parent 1677654dea
commit ac11c6729b
9 changed files with 81 additions and 87 deletions
--- a/tests/providers/aws/aws_provider_test.py
+++ b/tests/providers/aws/aws_provider_test.py
@@ -1,5 +1,6 @@
+from re import search
+
 import boto3
-import sure  # noqa
 from mock import patch
 from moto import mock_iam, mock_sts

@@ -214,27 +215,30 @@ class Test_AWS_Provider:
            credentials = assume_role_response["Credentials"]
            # Test the response
            # SessionToken
-            credentials["SessionToken"].should.have.length_of(356)
-            credentials["SessionToken"].startswith("FQoGZXIvYXdzE")
+            assert len(credentials["SessionToken"]) == 356
+            assert search(r"^FQoGZXIvYXdzE.*$", credentials["SessionToken"])
            # AccessKeyId
-            credentials["AccessKeyId"].should.have.length_of(20)
-            credentials["AccessKeyId"].startswith("ASIA")
+            assert len(credentials["AccessKeyId"]) == 20
+            assert search(r"^ASIA.*$", credentials["AccessKeyId"])
            # SecretAccessKey
-            credentials["SecretAccessKey"].should.have.length_of(40)
+            assert len(credentials["SecretAccessKey"]) == 40
            # Assumed Role
-            assume_role_response["AssumedRoleUser"]["Arn"].should.equal(
-                f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
+            assert (
+                assume_role_response["AssumedRoleUser"]["Arn"]
+                == f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
            )
+
            # AssumedRoleUser
-            assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].startswith(
-                "AROA"
+            assert search(
+                r"^AROA.*$", assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
            )
-            assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].endswith(
-                ":" + sessionName
+            assert search(
+                rf"^.*:{sessionName}$",
+                assume_role_response["AssumedRoleUser"]["AssumedRoleId"],
            )
-            assume_role_response["AssumedRoleUser"][
-                "AssumedRoleId"
-            ].should.have.length_of(21 + 1 + len(sessionName))
+            assert len(
+                assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
+            ) == 21 + 1 + len(sessionName)

    @mock_iam
    @mock_sts
@@ -301,27 +305,30 @@ class Test_AWS_Provider:
        credentials = assume_role_response["Credentials"]
        # Test the response
        # SessionToken
-        credentials["SessionToken"].should.have.length_of(356)
-        credentials["SessionToken"].startswith("FQoGZXIvYXdzE")
+        assert len(credentials["SessionToken"]) == 356
+        assert search(r"^FQoGZXIvYXdzE.*$", credentials["SessionToken"])
        # AccessKeyId
-        credentials["AccessKeyId"].should.have.length_of(20)
-        credentials["AccessKeyId"].startswith("ASIA")
+        assert len(credentials["AccessKeyId"]) == 20
+        assert search(r"^ASIA.*$", credentials["AccessKeyId"])
        # SecretAccessKey
-        credentials["SecretAccessKey"].should.have.length_of(40)
+        assert len(credentials["SecretAccessKey"]) == 40
        # Assumed Role
-        assume_role_response["AssumedRoleUser"]["Arn"].should.equal(
-            f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
+        assert (
+            assume_role_response["AssumedRoleUser"]["Arn"]
+            == f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
        )
+
        # AssumedRoleUser
-        assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].startswith(
-            "AROA"
+        assert search(
+            r"^AROA.*$", assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
        )
-        assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].endswith(
-            ":" + sessionName
-        )
-        assume_role_response["AssumedRoleUser"]["AssumedRoleId"].should.have.length_of(
-            21 + 1 + len(sessionName)
+        assert search(
+            rf"^.*:{sessionName}$",
+            assume_role_response["AssumedRoleUser"]["AssumedRoleId"],
        )
+        assert len(
+            assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
+        ) == 21 + 1 + len(sessionName)

    @mock_iam
    @mock_sts
@@ -390,27 +397,30 @@ class Test_AWS_Provider:
        credentials = assume_role_response["Credentials"]
        # Test the response
        # SessionToken
-        credentials["SessionToken"].should.have.length_of(356)
-        credentials["SessionToken"].startswith("FQoGZXIvYXdzE")
+        assert len(credentials["SessionToken"]) == 356
+        assert search(r"^FQoGZXIvYXdzE.*$", credentials["SessionToken"])
        # AccessKeyId
-        credentials["AccessKeyId"].should.have.length_of(20)
-        credentials["AccessKeyId"].startswith("ASIA")
+        assert len(credentials["AccessKeyId"]) == 20
+        assert search(r"^ASIA.*$", credentials["AccessKeyId"])
        # SecretAccessKey
-        credentials["SecretAccessKey"].should.have.length_of(40)
+        assert len(credentials["SecretAccessKey"]) == 40
        # Assumed Role
-        assume_role_response["AssumedRoleUser"]["Arn"].should.equal(
-            f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
+        assert (
+            assume_role_response["AssumedRoleUser"]["Arn"]
+            == f"arn:aws:sts::{ACCOUNT_ID}:assumed-role/{role_name}/{sessionName}"
        )
+
        # AssumedRoleUser
-        assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].startswith(
-            "AROA"
+        assert search(
+            r"^AROA.*$", assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
        )
-        assert assume_role_response["AssumedRoleUser"]["AssumedRoleId"].endswith(
-            ":" + sessionName
-        )
-        assume_role_response["AssumedRoleUser"]["AssumedRoleId"].should.have.length_of(
-            21 + 1 + len(sessionName)
+        assert search(
+            rf"^.*:{sessionName}$",
+            assume_role_response["AssumedRoleUser"]["AssumedRoleId"],
        )
+        assert len(
+            assume_role_response["AssumedRoleUser"]["AssumedRoleId"]
+        ) == 21 + 1 + len(sessionName)

    def test_generate_regional_clients(self):
        # New Boto3 session with the previously create user
--- a/tests/providers/aws/lib/arn/arn_test.py
+++ b/tests/providers/aws/lib/arn/arn_test.py
@@ -1,4 +1,3 @@
-import sure  # noqa
 from pytest import raises

 from prowler.providers.aws.lib.arn.arn import is_valid_arn, parse_iam_credentials_arn
@@ -250,12 +249,12 @@ class Test_ARN_Parsing:
        for test in test_cases:
            input_arn = test["input_arn"]
            parsed_arn = parse_iam_credentials_arn(input_arn)
-            parsed_arn.partition.should.equal(test["expected"]["partition"])
-            parsed_arn.service.should.equal(test["expected"]["service"])
-            parsed_arn.region.should.equal(test["expected"]["region"])
-            parsed_arn.account_id.should.equal(test["expected"]["account_id"])
-            parsed_arn.resource_type.should.equal(test["expected"]["resource_type"])
-            parsed_arn.resource.should.equal(test["expected"]["resource"])
+            assert parsed_arn.partition == test["expected"]["partition"]
+            assert parsed_arn.service == test["expected"]["service"]
+            assert parsed_arn.region == test["expected"]["region"]
+            assert parsed_arn.account_id == test["expected"]["account_id"]
+            assert parsed_arn.resource_type == test["expected"]["resource_type"]
+            assert parsed_arn.resource == test["expected"]["resource"]

    def test_iam_credentials_arn_parsing_raising_RoleArnParsingFailedMissingFields(
        self,
--- a/tests/providers/aws/lib/organizations/organizations_test.py
+++ b/tests/providers/aws/lib/organizations/organizations_test.py
@@ -1,7 +1,6 @@
 import json

 import boto3
-import sure  # noqa
 from moto import mock_iam, mock_organizations, mock_sts

 from prowler.providers.aws.lib.organizations.organizations import (
@@ -52,10 +51,11 @@ class Test_AWS_Organizations:

        org = get_organizations_metadata(account_id, assumed_role)

-        org.account_details_email.should.equal(mockemail)
-        org.account_details_name.should.equal(mockname)
-        org.account_details_arn.should.equal(
-            f"arn:aws:organizations::{AWS_ACCOUNT_NUMBER}:account/{org_id}/{account_id}"
+        assert org.account_details_email == mockemail
+        assert org.account_details_name == mockname
+        assert (
+            org.account_details_arn
+            == f"arn:aws:organizations::{AWS_ACCOUNT_NUMBER}:account/{org_id}/{account_id}"
        )
-        org.account_details_org.should.equal(org_id)
-        org.account_details_tags.should.equal("key:value,")
+        assert org.account_details_org == org_id
+        assert org.account_details_tags == "key:value,"
--- a/tests/providers/common/audit_info_test.py
+++ b/tests/providers/common/audit_info_test.py
@@ -1,7 +1,6 @@
 import boto3
 import botocore
 import pytest
-import sure  # noqa
 from boto3 import session
 from mock import patch
 from moto import mock_ec2, mock_resourcegroupstaggingapi