From b4e78d28f8a84f22bcfa09860099f65eeafbc6c3 Mon Sep 17 00:00:00 2001 From: Pepe Fagoaga Date: Mon, 31 Jul 2023 11:19:15 +0200 Subject: [PATCH] fix(test): mock VPC client (#2640) --- .../vpc_flow_logs_enabled_test.py | 33 +++++++++++-------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/tests/providers/aws/services/vpc/vpc_flow_logs_enabled/vpc_flow_logs_enabled_test.py b/tests/providers/aws/services/vpc/vpc_flow_logs_enabled/vpc_flow_logs_enabled_test.py index 48abd50f..5f61e34f 100644 --- a/tests/providers/aws/services/vpc/vpc_flow_logs_enabled/vpc_flow_logs_enabled_test.py +++ b/tests/providers/aws/services/vpc/vpc_flow_logs_enabled/vpc_flow_logs_enabled_test.py @@ -50,25 +50,24 @@ class Test_vpc_flow_logs_enabled: with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", new=current_audit_info, + ), mock.patch( + "prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled.vpc_client", + new=VPC(current_audit_info), ): - with mock.patch( - "prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled.vpc_client", - new=VPC(current_audit_info), - ): - # Test Check - from prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled import ( - vpc_flow_logs_enabled, - ) + # Test Check + from prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled import ( + vpc_flow_logs_enabled, + ) - check = vpc_flow_logs_enabled() - result = check.execute() + check = vpc_flow_logs_enabled() + result = check.execute() - assert ( - len(result) == 2 - ) # Number of AWS regions, one default VPC per region + assert len(result) == 2 # Number of AWS regions, one default VPC per region @mock_ec2 def test_vpc_with_flow_logs(self): + from prowler.providers.aws.services.vpc.vpc_service import VPC + # Create VPC Mocked Resources ec2_client = client("ec2", region_name=AWS_REGION) @@ -90,6 +89,9 @@ class Test_vpc_flow_logs_enabled: with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", new=current_audit_info, + ), mock.patch( + "prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled.vpc_client", + new=VPC(current_audit_info), ): # Test Check from prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled import ( @@ -111,6 +113,8 @@ class Test_vpc_flow_logs_enabled: @mock_ec2 def test_vpc_without_flow_logs(self): + from prowler.providers.aws.services.vpc.vpc_service import VPC + # Create VPC Mocked Resources ec2_client = client("ec2", region_name=AWS_REGION) @@ -121,6 +125,9 @@ class Test_vpc_flow_logs_enabled: with mock.patch( "prowler.providers.aws.lib.audit_info.audit_info.current_audit_info", new=current_audit_info, + ), mock.patch( + "prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled.vpc_client", + new=VPC(current_audit_info), ): # Test Check from prowler.providers.aws.services.vpc.vpc_flow_logs_enabled.vpc_flow_logs_enabled import (