diff --git a/tests/providers/aws/services/wellarchitected/wellarchitected_service_test.py b/tests/providers/aws/services/wellarchitected/wellarchitected_service_test.py index 345a937b..e88cc323 100644 --- a/tests/providers/aws/services/wellarchitected/wellarchitected_service_test.py +++ b/tests/providers/aws/services/wellarchitected/wellarchitected_service_test.py @@ -2,17 +2,15 @@ from unittest.mock import patch from uuid import uuid4 import botocore -from boto3 import session -from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info from prowler.providers.aws.services.wellarchitected.wellarchitected_service import ( WellArchitected, ) -from prowler.providers.common.models import Audit_Metadata - -AWS_ACCOUNT_NUMBER = "123456789012" -AWS_REGION = "eu-west-1" - +from tests.providers.aws.audit_info_utils import ( + AWS_ACCOUNT_NUMBER, + AWS_REGION_EU_WEST_1, + set_mocked_aws_audit_info, +) workload_id = str(uuid4()) @@ -25,7 +23,7 @@ def mock_make_api_call(self, operation_name, kwarg): "WorkloadSummaries": [ { "WorkloadId": workload_id, - "WorkloadArn": f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", + "WorkloadArn": f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", "WorkloadName": "test", "Owner": AWS_ACCOUNT_NUMBER, "UpdatedAt": "2023-06-07T15:40:24+02:00", @@ -43,9 +41,11 @@ def mock_make_api_call(self, operation_name, kwarg): def mock_generate_regional_clients(service, audit_info, _): - regional_client = audit_info.audit_session.client(service, region_name=AWS_REGION) - regional_client.region = AWS_REGION - return {AWS_REGION: regional_client} + regional_client = audit_info.audit_session.client( + service, region_name=AWS_REGION_EU_WEST_1 + ) + regional_client.region = AWS_REGION_EU_WEST_1 + return {AWS_REGION_EU_WEST_1: regional_client} @patch("botocore.client.BaseClient._make_api_call", new=mock_make_api_call) @@ -54,68 +54,38 @@ def mock_generate_regional_clients(service, audit_info, _): new=mock_generate_regional_clients, ) class Test_WellArchitected_Service: - # Mocked Audit Info - def set_mocked_audit_info(self): - audit_info = AWS_Audit_Info( - session_config=None, - original_session=None, - audit_session=session.Session( - profile_name=None, - botocore_session=None, - ), - audited_account=AWS_ACCOUNT_NUMBER, - audited_account_arn=f"arn:aws:iam::{AWS_ACCOUNT_NUMBER}:root", - audited_user_id=None, - audited_partition="aws", - audited_identity_arn=None, - profile=None, - profile_region=None, - credentials=None, - assumed_role_info=None, - audited_regions=None, - organizations_metadata=None, - audit_resources=None, - mfa_enabled=False, - audit_metadata=Audit_Metadata( - services_scanned=0, - expected_checks=[], - completed_checks=0, - audit_progress=0, - ), - ) - return audit_info # Test WellArchitected Service def test_service(self): - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_EU_WEST_1]) wellarchitected = WellArchitected(audit_info) assert wellarchitected.service == "wellarchitected" # Test WellArchitected client def test_client(self): - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_EU_WEST_1]) wellarchitected = WellArchitected(audit_info) for reg_client in wellarchitected.regional_clients.values(): assert reg_client.__class__.__name__ == "WellArchitected" # Test WellArchitected session def test__get_session__(self): - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_EU_WEST_1]) wellarchitected = WellArchitected(audit_info) assert wellarchitected.session.__class__.__name__ == "Session" # Test WellArchitected list workloads def test__list_workloads__(self): - audit_info = self.set_mocked_audit_info() + audit_info = set_mocked_aws_audit_info([AWS_REGION_EU_WEST_1]) wellarchitected = WellArchitected(audit_info) assert len(wellarchitected.workloads) == 1 assert wellarchitected.workloads[0].id == workload_id assert ( wellarchitected.workloads[0].arn - == f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" + == f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" ) assert wellarchitected.workloads[0].name == "test" - assert wellarchitected.workloads[0].region == AWS_REGION + assert wellarchitected.workloads[0].region == AWS_REGION_EU_WEST_1 assert wellarchitected.workloads[0].tags == [ {"Key": "test", "Value": "test"}, ] diff --git a/tests/providers/aws/services/wellarchitected/wellarchitected_workload_no_high_or_medium_risks/wellarchitected_workload_no_high_or_medium_risks_test.py b/tests/providers/aws/services/wellarchitected/wellarchitected_workload_no_high_or_medium_risks/wellarchitected_workload_no_high_or_medium_risks_test.py index 9d6cd2f2..99e0ce76 100644 --- a/tests/providers/aws/services/wellarchitected/wellarchitected_workload_no_high_or_medium_risks/wellarchitected_workload_no_high_or_medium_risks_test.py +++ b/tests/providers/aws/services/wellarchitected/wellarchitected_workload_no_high_or_medium_risks/wellarchitected_workload_no_high_or_medium_risks_test.py @@ -5,9 +5,10 @@ from uuid import uuid4 from prowler.providers.aws.services.wellarchitected.wellarchitected_service import ( Workload, ) - -AWS_REGION = "eu-west-1" -AWS_ACCOUNT_NUMBER = "123456789012" +from tests.providers.aws.audit_info_utils import ( + AWS_ACCOUNT_NUMBER, + AWS_REGION_EU_WEST_1, +) workload_id = str(uuid4()) @@ -37,12 +38,12 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: wellarchitected_client.workloads.append( Workload( id=workload_id, - arn=f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", + arn=f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", name="test", lenses=["wellarchitected", "serverless", "softwareasaservice"], improvement_status="NOT_APPLICABLE", risks={}, - region=AWS_REGION, + region=AWS_REGION_EU_WEST_1, ) ) with mock.patch( @@ -66,7 +67,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: assert result[0].resource_id == workload_id assert ( result[0].resource_arn - == f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" + == f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" ) def test_wellarchitected_no_high_medium_risks(self): @@ -75,7 +76,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: wellarchitected_client.workloads.append( Workload( id=workload_id, - arn=f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", + arn=f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", name="test", lenses=["wellarchitected", "serverless", "softwareasaservice"], improvement_status="NOT_APPLICABLE", @@ -83,7 +84,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: "UNANSWERED": 56, "NOT_APPLICABLE": 4, }, - region=AWS_REGION, + region=AWS_REGION_EU_WEST_1, ) ) with mock.patch( @@ -107,7 +108,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: assert result[0].resource_id == workload_id assert ( result[0].resource_arn - == f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" + == f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" ) def test_wellarchitected_with_high_medium_risks(self): @@ -116,7 +117,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: wellarchitected_client.workloads.append( Workload( id=workload_id, - arn=f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", + arn=f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}", name="test", lenses=["wellarchitected", "serverless", "softwareasaservice"], improvement_status="NOT_APPLICABLE", @@ -126,7 +127,7 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: "HIGH": 10, "MEDIUM": 20, }, - region=AWS_REGION, + region=AWS_REGION_EU_WEST_1, ) ) with mock.patch( @@ -150,5 +151,5 @@ class Test_wellarchitected_workload_no_high_or_medium_risks: assert result[0].resource_id == workload_id assert ( result[0].resource_arn - == f"arn:aws:wellarchitected:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" + == f"arn:aws:wellarchitected:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:workload/{workload_id}" )