ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(metadata): Remove CheckName and CheckAlias field (#1299)

Browse Source
This commit is contained in:
Pepe Fagoaga
2022-08-03 10:12:34 +02:00
committed by GitHub
parent 9f82a8a6d6
commit dfbc618d44
26 changed files with 7 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/check/check.py
View File

@@ -192,9 +192,9 @@ def set_output_options(
def run_check(check, audit_info, output_options):
print(
f"\nCheck Name: {check.checkName} - {Fore.MAGENTA}{check.serviceName}{Fore.YELLOW} [{check.severity}]{Style.RESET_ALL}"
f"\nCheck ID: {check.checkID} - {Fore.MAGENTA}{check.serviceName}{Fore.YELLOW} [{check.severity}]{Style.RESET_ALL}"
)
logger.debug(f"Executing check: {check.checkName}")
logger.debug(f"Executing check: {check.checkID}")
findings = check.execute()
report(findings, output_options, audit_info)

2
lib/check/fixtures/metadata.json
View File

@@ -3,9 +3,7 @@
"cat1",
"cat2"
],
"CheckAlias": "extra764",
"CheckID": "iam_disable_30_days_credentials",
"CheckName": "iam_disable_30_days_credentials",
"CheckTitle": "Ensure credentials unused for 30 days or greater are disabled",
"CheckType": "Software and Configuration Checks",
"Compliance": [

10
lib/check/models.py
View File

@@ -54,7 +54,7 @@ class Remediation(BaseModel):
class Check_Metadata_Model(BaseModel):
Provider: str
CheckID: str
CheckName: str
# CheckName: str
CheckTitle: str
# CheckAlias: str
CheckType: str
@@ -84,7 +84,7 @@ class Check(ABC):
# Assign metadata values
self.__Provider__ = self.__check_metadata__.Provider
self.__CheckID__ = self.__check_metadata__.CheckID
self.__CheckName__ = self.__check_metadata__.CheckName
# self.__CheckName__ = self.__check_metadata__.CheckName
self.__CheckTitle__ = self.__check_metadata__.CheckTitle
# self.__CheckAlias__ = self.__check_metadata__.CheckAlias
self.__CheckType__ = self.__check_metadata__.CheckType
@@ -112,9 +112,9 @@ class Check(ABC):
def checkID(self):
return self.__CheckID__
@property
def checkName(self):
return self.__CheckName__
# @property
# def checkName(self):
# return self.__CheckName__
@property
def checkTitle(self):