From e7212519361f293391cd8ba1e9f4a6e2b9fd099d Mon Sep 17 00:00:00 2001
From: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Date: Wed, 26 Jul 2023 08:49:09 +0200
Subject: [PATCH] fix(compute): solve key errors in compute service (#2610)

---
 .../gcp/services/compute/compute_service.py      | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/prowler/providers/gcp/services/compute/compute_service.py b/prowler/providers/gcp/services/compute/compute_service.py
index a59d306e..6a378918 100644
--- a/prowler/providers/gcp/services/compute/compute_service.py
+++ b/prowler/providers/gcp/services/compute/compute_service.py
@@ -112,10 +112,12 @@ class Compute:
                                     shielded_enabled_integrity_monitoring=instance[
                                         "shieldedInstanceConfig"
                                     ]["enableIntegrityMonitoring"],
-                                    confidential_computing=instance[
-                                        "confidentialInstanceConfig"
-                                    ]["enableConfidentialCompute"],
-                                    service_accounts=instance["serviceAccounts"],
+                                    confidential_computing=instance.get(
+                                        "confidentialInstanceConfig", {}
+                                    ).get("enableConfidentialCompute", False),
+                                    service_accounts=instance.get(
+                                        "serviceAccounts", []
+                                    ),
                                     ip_forward=instance.get("canIpForward", False),
                                     disks_encryption=[
                                         (
@@ -212,7 +214,7 @@ class Compute:
                             Firewall(
                                 name=firewall["name"],
                                 id=firewall["id"],
-                                source_ranges=firewall["sourceRanges"],
+                                source_ranges=firewall.get("sourceRanges", []),
                                 direction=firewall["direction"],
                                 allowed_rules=firewall.get("allowed", []),
                                 project_id=project_id,
@@ -238,7 +240,7 @@ class Compute:
                             LoadBalancer(
                                 name=urlmap["name"],
                                 id=urlmap["id"],
-                                service=urlmap["defaultService"],
+                                service=urlmap.get("defaultService", ""),
                                 project_id=project_id,
                             )
                         )
@@ -262,7 +264,7 @@ class Compute:
                     )
                     .execute()
                 )
-                balancer.logging = response.get("logConfig", False).get("enable", False)
+                balancer.logging = response.get("logConfig", {}).get("enable", False)
             except Exception as error:
                 logger.error(
                     f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"