test(audit_info): refactor shub (#3133)

This commit is contained in:
Nacho Rivera
2023-12-05 11:33:34 +01:00
committed by GitHub
parent b861c1dd3c
commit f0da63c850
2 changed files with 22 additions and 55 deletions

View File

@@ -3,16 +3,13 @@ from unittest import mock
from prowler.providers.aws.services.securityhub.securityhub_service import (
SecurityHubHub,
)
AWS_REGION = "eu-west-1"
AWS_ACCOUNT_ID = "123456789012"
AWS_ACCOUNT_ARN = f"arn:aws:iam::{AWS_ACCOUNT_ID}:root"
from tests.providers.aws.audit_info_utils import AWS_ACCOUNT_ARN, AWS_REGION_EU_WEST_1
class Test_securityhub_enabled:
def test_securityhub_hub_inactive(self):
securityhub_client = mock.MagicMock
securityhub_client.region = AWS_REGION
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.securityhubs = [
SecurityHubHub(
arn=AWS_ACCOUNT_ARN,
@@ -20,7 +17,7 @@ class Test_securityhub_enabled:
status="NOT_AVAILABLE",
standards="",
integrations="",
region=AWS_REGION,
region=AWS_REGION_EU_WEST_1,
)
]
with mock.patch(
@@ -39,7 +36,7 @@ class Test_securityhub_enabled:
assert result[0].status_extended == "Security Hub is not enabled."
assert result[0].resource_id == "Security Hub"
assert result[0].resource_arn == AWS_ACCOUNT_ARN
assert result[0].region == AWS_REGION
assert result[0].region == AWS_REGION_EU_WEST_1
def test_securityhub_hub_active_with_standards(self):
securityhub_client = mock.MagicMock
@@ -75,7 +72,7 @@ class Test_securityhub_enabled:
result[0].resource_arn
== "arn:aws:securityhub:us-east-1:0123456789012:hub/default"
)
assert result[0].region == AWS_REGION
assert result[0].region == AWS_REGION_EU_WEST_1
def test_securityhub_hub_active_with_integrations(self):
securityhub_client = mock.MagicMock
@@ -111,11 +108,11 @@ class Test_securityhub_enabled:
result[0].resource_arn
== "arn:aws:securityhub:us-east-1:0123456789012:hub/default"
)
assert result[0].region == AWS_REGION
assert result[0].region == AWS_REGION_EU_WEST_1
def test_securityhub_hub_active_without_integrations_or_standards(self):
securityhub_client = mock.MagicMock
securityhub_client.region = AWS_REGION
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.securityhubs = [
SecurityHubHub(
arn="arn:aws:securityhub:us-east-1:0123456789012:hub/default",
@@ -148,12 +145,12 @@ class Test_securityhub_enabled:
result[0].resource_arn
== "arn:aws:securityhub:us-east-1:0123456789012:hub/default"
)
assert result[0].region == AWS_REGION
assert result[0].region == AWS_REGION_EU_WEST_1
def test_securityhub_hub_active_without_integrations_or_standards_allowlisted(self):
securityhub_client = mock.MagicMock
securityhub_client.audit_config = {"allowlist_non_default_regions": True}
securityhub_client.region = AWS_REGION
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.securityhubs = [
SecurityHubHub(
arn="arn:aws:securityhub:us-east-1:0123456789012:hub/default",