mirror of
https://github.com/ghndrx/prowler.git
synced 2026-02-14 12:14:59 +00:00
fix(check): change cloudformation_outputs_find_secrets name (#2027)
This commit is contained in:
@@ -517,10 +517,8 @@ def get_checks_from_input_arn(audit_resources: list, provider: str) -> set:
|
||||
for resource in audit_resources:
|
||||
service = resource.split(":")[2]
|
||||
sub_service = resource.split(":")[5].split("/")[0].replace("-", "_")
|
||||
|
||||
if (
|
||||
service != "wafv2" and service != "waf"
|
||||
): # WAF Services does not have checks
|
||||
# WAF Services does not have checks
|
||||
if service != "wafv2" and service != "waf":
|
||||
# Parse services when they are different in the ARNs
|
||||
if service == "lambda":
|
||||
service = "awslambda"
|
||||
@@ -528,7 +526,14 @@ def get_checks_from_input_arn(audit_resources: list, provider: str) -> set:
|
||||
service = "elb"
|
||||
elif service == "logs":
|
||||
service = "cloudwatch"
|
||||
service_list.add(service)
|
||||
# Check if Prowler has checks in service
|
||||
try:
|
||||
list_modules(provider, service)
|
||||
except ModuleNotFoundError:
|
||||
# Service is not supported
|
||||
pass
|
||||
else:
|
||||
service_list.add(service)
|
||||
|
||||
# Get subservices to execute only applicable checks
|
||||
if service not in services_without_subservices:
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"Provider": "aws",
|
||||
"CheckID": "cloudformation_outputs_find_secrets",
|
||||
"CheckID": "cloudformation_stack_outputs_find_secrets",
|
||||
"CheckTitle": "Find secrets in CloudFormation outputs",
|
||||
"CheckType": [],
|
||||
"ServiceName": "cloudformation",
|
||||
@@ -10,11 +10,11 @@ from prowler.providers.aws.services.cloudformation.cloudformation_client import
|
||||
)
|
||||
|
||||
|
||||
class cloudformation_outputs_find_secrets(Check):
|
||||
class cloudformation_stack_outputs_find_secrets(Check):
|
||||
"""Check if a CloudFormation Stack has secrets in their Outputs"""
|
||||
|
||||
def execute(self):
|
||||
"""Execute the cloudformation_outputs_find_secrets check"""
|
||||
"""Execute the cloudformation_stack_outputs_find_secrets check"""
|
||||
findings = []
|
||||
for stack in cloudformation_client.stacks:
|
||||
report = Check_Report_AWS(self.metadata())
|
||||
Reference in New Issue
Block a user