From f7737a9efd68dd69841f3499cc69bfb2f2e7c9e5 Mon Sep 17 00:00:00 2001 From: Nathan Haneysmith Date: Wed, 13 Jun 2018 14:18:22 -0700 Subject: [PATCH] Fix extra727 and extra728 #221 --- checks/check_extra727 | 2 +- checks/check_extra728 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/checks/check_extra727 b/checks/check_extra727 index 2356684c..2fda18d3 100644 --- a/checks/check_extra727 +++ b/checks/check_extra727 @@ -23,7 +23,7 @@ extra727(){ if [[ $LIST_SQS ]]; then for queue in $LIST_SQS; do # check if the policy has Principal as * - PUBLIC_SQS=$($AWSCLI sqs get-queue-attributes --queue-url $queue --region $regx --attribute-names All --query Attributes.Policy --output text | awk -v k="text" '{n=split($0,a,","); for (i=1; i<=n; i++) print a[i]}' | awk '/Principal/ && !skip { print } { skip = /Deny/} '|grep \"Principal|grep \*) + PUBLIC_SQS=$($AWSCLI sqs get-queue-attributes --queue-url $queue $PROFILE_OPT --region $regx --attribute-names All --query Attributes.Policy --output text | awk -v k="text" '{n=split($0,a,","); for (i=1; i<=n; i++) print a[i]}' | awk '/Principal/ && !skip { print } { skip = /Deny/} '|grep \"Principal|grep \*) if [[ $PUBLIC_SQS ]]; then textFail "$regx: SQS queue $queue seems to be public (Principal: \"*\")" "$regx" else diff --git a/checks/check_extra728 b/checks/check_extra728 index 7f4e4be0..eb27a9de 100644 --- a/checks/check_extra728 +++ b/checks/check_extra728 @@ -23,7 +23,7 @@ extra728(){ if [[ $LIST_SQS ]]; then for queue in $LIST_SQS; do # check if the policy has KmsMasterKeyId therefore SSE enabled - SSE_ENABLED_QUEUE=$($AWSCLI sqs get-queue-attributes --queue-url $queue --region $regx --attribute-names All --query Attributes.KmsMasterKeyId --output text|grep -v ^None) + SSE_ENABLED_QUEUE=$($AWSCLI sqs get-queue-attributes --queue-url $queue $PROFILE_OPT --region $regx --attribute-names All --query Attributes.KmsMasterKeyId --output text|grep -v ^None) if [[ $SSE_ENABLED_QUEUE ]]; then textPass "$regx: SQS queue $queue is using Server Side Encryption" "$regx" else