ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(rds): remove DocumentDB from RDS (#1737)

Browse Source 
Co-authored-by: sergargar <sergio@verica.io>
This commit is contained in:
Sergio Garcia
2023-01-20 09:31:19 +01:00
committed by GitHub
parent 6b9520338e
commit f88b35bd80
1 changed files with 40 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
prowler/providers/aws/services/rds/rds_service.py
View File

@@ -43,30 +43,32 @@ class RDS:
) )
for page in describe_db_instances_paginator.paginate(): for page in describe_db_instances_paginator.paginate():
for instance in page["DBInstances"]: for instance in page["DBInstances"]:
self.db_instances.append( if instance["Engine"] != "docdb":
DBInstance( self.db_instances.append(
id=instance["DBInstanceIdentifier"], DBInstance(
endpoint=instance["Endpoint"]["Address"], id=instance["DBInstanceIdentifier"],
status=instance["DBInstanceStatus"], endpoint=instance["Endpoint"]["Address"],
public=instance["PubliclyAccessible"], engine=instance["Engine"],
encrypted=instance["StorageEncrypted"], status=instance["DBInstanceStatus"],
auto_minor_version_upgrade=instance[ public=instance["PubliclyAccessible"],
"AutoMinorVersionUpgrade" encrypted=instance["StorageEncrypted"],
], auto_minor_version_upgrade=instance[
backup_retention_period=instance.get( "AutoMinorVersionUpgrade"
"BackupRetentionPeriod" ],
), backup_retention_period=instance.get(
cloudwatch_logs=instance.get( "BackupRetentionPeriod"
"EnabledCloudwatchLogsExports" ),
), cloudwatch_logs=instance.get(
deletion_protection=instance["DeletionProtection"], "EnabledCloudwatchLogsExports"
enhanced_monitoring_arn=instance.get( ),
"EnhancedMonitoringResourceArn" deletion_protection=instance["DeletionProtection"],
), enhanced_monitoring_arn=instance.get(
multi_az=instance["MultiAZ"], "EnhancedMonitoringResourceArn"
region=regional_client.region, ),
multi_az=instance["MultiAZ"],
region=regional_client.region,
)
) )
)
except Exception as error: except Exception as error:
logger.error( logger.error(
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
@@ -80,13 +82,14 @@ class RDS:
) )
for page in describe_db_snapshots_paginator.paginate(): for page in describe_db_snapshots_paginator.paginate():
for snapshot in page["DBSnapshots"]: for snapshot in page["DBSnapshots"]:
self.db_snapshots.append( if snapshot["Engine"] != "docdb":
DBSnapshot( self.db_snapshots.append(
id=snapshot["DBSnapshotIdentifier"], DBSnapshot(
instance_id=snapshot["DBInstanceIdentifier"], id=snapshot["DBSnapshotIdentifier"],
region=regional_client.region, instance_id=snapshot["DBInstanceIdentifier"],
region=regional_client.region,
)
) )
)
except Exception as error: except Exception as error:
logger.error( logger.error(
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
@@ -117,13 +120,14 @@ class RDS:
) )
for page in describe_db_snapshots_paginator.paginate(): for page in describe_db_snapshots_paginator.paginate():
for snapshot in page["DBClusterSnapshots"]: for snapshot in page["DBClusterSnapshots"]:
self.db_cluster_snapshots.append( if snapshot["Engine"] != "docdb":
ClusterSnapshot( self.db_cluster_snapshots.append(
id=snapshot["DBClusterSnapshotIdentifier"], ClusterSnapshot(
cluster_id=snapshot["DBClusterIdentifier"], id=snapshot["DBClusterSnapshotIdentifier"],
region=regional_client.region, cluster_id=snapshot["DBClusterIdentifier"],
region=regional_client.region,
)
) )
)
except Exception as error: except Exception as error:
logger.error( logger.error(
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
@@ -150,6 +154,7 @@ class RDS:
class DBInstance(BaseModel): class DBInstance(BaseModel):
id: str id: str
endpoint: str endpoint: str
engine: str
status: str status: str
public: bool public: bool
encrypted: bool encrypted: bool