From fc3f4e830e4489b68270ef194d7cac65ddd67ddb Mon Sep 17 00:00:00 2001 From: Nimrod Kor Date: Tue, 17 Dec 2019 09:29:06 +0200 Subject: [PATCH] Reuse ACCOUNT_NUM --- checks/check26 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/checks/check26 b/checks/check26 index 41281b56..0c6dfa0c 100644 --- a/checks/check26 +++ b/checks/check26 @@ -18,7 +18,6 @@ check26(){ # "Ensure S3 bucket access logging is enabled on the CloudTrail S3 bucket (Scored)" CLOUDTRAILS=$($AWSCLI cloudtrail describe-trails $PROFILE_OPT --region "$REGION" --query 'trailList[*].Name' --output text| tr '\011' '\012' | awk -F: '{print $1}') - ACCOUNT_ID=$($AWSCLI sts get-caller-identity --output json $PROFILE_OPT --region $REGION --query "Account" | tr -d '"') if [[ $CLOUDTRAILS ]];then for trail in $CLOUDTRAILS; do @@ -27,7 +26,7 @@ check26(){ if [[ $CLOUDTRAILBUCKET ]];then bucket=$CLOUDTRAILBUCKET - if [ "$CLOUDTRAIL_ACCOUNT_ID" == "$ACCOUNT_ID" ];then + if [ "$CLOUDTRAIL_ACCOUNT_ID" == "$ACCOUNT_NUM" ];then CLOUDTRAILBUCKET_LOGENABLED=$($AWSCLI s3api get-bucket-logging --bucket $bucket $PROFILE_OPT --region $REGION --query 'LoggingEnabled.TargetBucket' --output text|grep -v None) if [[ $CLOUDTRAILBUCKET_LOGENABLED ]];then textPass "Bucket access logging enabled in CloudTrail S3 bucket $bucket for $trail"