mirror of
https://github.com/ghndrx/prowler.git
synced 2026-02-11 07:15:15 +00:00
4961498562
Added a third parameter to checks textFail and textPass to identify resource name in finding.
66 lines
3.8 KiB
Bash
66 lines
3.8 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Prowler - the handy cloud security tool (copyright 2019) by Toni de la Fuente
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
|
|
# use this file except in compliance with the License. You may obtain a copy
|
|
# of the License at http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software distributed
|
|
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
|
|
# CONDITIONS OF ANY KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations under the License.
|
|
CHECK_ID_extra768="7.68"
|
|
CHECK_TITLE_extra768="[extra768] Find secrets in ECS task definitions variables (Not Scored) (Not part of CIS benchmark)"
|
|
CHECK_SCORED_extra768="NOT_SCORED"
|
|
CHECK_TYPE_extra768="EXTRA"
|
|
CHECK_SEVERITY_extra768="Critical"
|
|
CHECK_ASFF_RESOURCE_TYPE_extra768="AwsEcsTaskDefinition"
|
|
CHECK_ALTERNATE_check768="extra768"
|
|
CHECK_SERVICENAME_extra768="ecs"
|
|
CHECK_RISK_extra768='The use of a hard-coded password increases the possibility of password guessing. If hard-coded passwords are used; it is possible that malicious users gain access through the account in question.'
|
|
CHECK_REMEDIATION_extra768='Use Secrets Manager to securely provide database credentials to Lambda functions and secure the databases as well as use the credentials to connect and query them without hardcoding the secrets in code or passing them through environmental variables. '
|
|
CHECK_DOC_extra768='https://docs.aws.amazon.com/secretsmanager/latest/userguide/lambda-functions.html'
|
|
CHECK_CAF_EPIC_extra768='Logging and Monitoring'
|
|
|
|
extra768(){
|
|
SECRETS_TEMP_FOLDER="$PROWLER_DIR/secrets-$ACCOUNT_NUM"
|
|
if [[ ! -d $SECRETS_TEMP_FOLDER ]]; then
|
|
# this folder is deleted once this check is finished
|
|
mkdir $SECRETS_TEMP_FOLDER
|
|
fi
|
|
textInfo "Looking for secrets in ECS task definitions' environment variables across all regions... "
|
|
for regx in $REGIONS; do
|
|
# Get a list of all families first:
|
|
FAMILIES=$($AWSCLI ecs list-task-definition-families $PROFILE_OPT --region $regx --status ACTIVE | jq -r .families[])
|
|
if [[ $FAMILIES ]]; then
|
|
for FAMILY in $FAMILIES;do
|
|
# Get the full task definition arn:
|
|
TASK_DEFINITION_TEMP=$($AWSCLI ecs list-task-definitions $PROFILE_OPT --region $regx --family-prefix $FAMILY --sort DESC --max-items 1 | jq -r .taskDefinitionArns[0])
|
|
# We only care about the task definition name:
|
|
IFS='/' read -r -a splitArn <<< "$TASK_DEFINITION_TEMP"
|
|
TASK_DEFINITION=${splitArn[1]}
|
|
TASK_DEFINITION_ENV_VARIABLES_FILE="$SECRETS_TEMP_FOLDER/extra768-$TASK_DEFINITION-$regx-variables.txt"
|
|
TASK_DEFINITION_ENV_VARIABLES=$($AWSCLI ecs $PROFILE_OPT --region $regx describe-task-definition --task-definition $TASK_DEFINITION --query 'taskDefinition.containerDefinitions[*].environment' --output text > $TASK_DEFINITION_ENV_VARIABLES_FILE)
|
|
if [ -s $TASK_DEFINITION_ENV_VARIABLES_FILE ];then
|
|
# Implementation using https://github.com/Yelp/detect-secrets
|
|
FINDINGS=$(secretsDetector file $TASK_DEFINITION_ENV_VARIABLES_FILE)
|
|
if [[ $FINDINGS -eq 0 ]]; then
|
|
textPass "$regx: No secrets found in ECS task definition $TASK_DEFINITION variables" "$regx" "$TASK_DEFINITION"
|
|
# delete file if nothing interesting is there
|
|
rm -f $TASK_DEFINITION_ENV_VARIABLES_FILE
|
|
else
|
|
textFail "$regx: Potential secret found in ECS task definition $TASK_DEFINITION variables" "$regx" "$TASK_DEFINITION"
|
|
fi
|
|
else
|
|
textInfo "$regx: ECS task definition $TASK_DEFINITION has no variables" "$regx"
|
|
rm -f $TASK_DEFINITION_ENV_VARIABLES_FILE
|
|
fi
|
|
done
|
|
else
|
|
textInfo "$regx: No ECS task definitions found" "$regx"
|
|
fi
|
|
done
|
|
# rm -rf $SECRETS_TEMP_FOLDER
|
|
}
|