fix(KeyError): handle service key errors (#1831)

This commit is contained in:
Sergio Garcia
2023-02-03 12:28:23 +01:00
committed by GitHub
parent 98eec332d8
commit 0164574fdd
2 changed files with 8 additions and 5 deletions

View File

@@ -94,10 +94,12 @@ class OpenSearchService:
DomainName=domain.name
)
domain.arn = describe_domain["DomainStatus"]["ARN"]
if "vpc" in describe_domain["DomainStatus"]["Endpoints"]:
domain.endpoint_vpc = describe_domain["DomainStatus"]["Endpoints"][
"vpc"
]
domain.endpoint_vpc = None
if "Endpoints" in describe_domain["DomainStatus"]:
if "vpc" in describe_domain["DomainStatus"]["Endpoints"]:
domain.endpoint_vpc = describe_domain["DomainStatus"][
"Endpoints"
]["vpc"]
domain.vpc_id = describe_domain["DomainStatus"]["VPCOptions"]["VPCId"]
domain.cognito_options = describe_domain["DomainStatus"][
"CognitoOptions"

View File

@@ -45,7 +45,8 @@ class s3_bucket_public_access(Check):
if bucket.policy:
for statement in bucket.policy["Statement"]:
if (
"*" == statement["Principal"]
"Principal" in statement
and "*" == statement["Principal"]
and statement["Effect"] == "Allow"
):
report.status = "FAIL"