ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ds): GetSnapshotLimits for MicrosoftAD (#2859)

Browse Source
This commit is contained in:
Pepe Fagoaga
2023-09-22 11:22:42 +02:00
committed by GitHub
parent 18e34c670e
commit 2a5a07bae0
1 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
prowler/providers/aws/services/directoryservice/directoryservice_service.py
View File

@@ -185,23 +185,29 @@ class DirectoryService(AWSService):
# Snapshot limits can be fetched only for VPC or Microsoft AD directories.
if (
directory.region == regional_client.region
and directory.type != DirectoryType.ADConnector
and directory.type == DirectoryType.MicrosoftAD
):
get_snapshot_limits_parameters = {"DirectoryId": directory.id}
snapshot_limit = regional_client.get_snapshot_limits(
**get_snapshot_limits_parameters
)
self.directories[directory.id].snapshots_limits = SnapshotLimit(
manual_snapshots_current_count=snapshot_limit["SnapshotLimits"][
"ManualSnapshotsCurrentCount"
],
manual_snapshots_limit=snapshot_limit["SnapshotLimits"][
"ManualSnapshotsLimit"
],
manual_snapshots_limit_reached=snapshot_limit["SnapshotLimits"][
"ManualSnapshotsLimitReached"
],
)
try:
get_snapshot_limits_parameters = {"DirectoryId": directory.id}
snapshot_limit = regional_client.get_snapshot_limits(
**get_snapshot_limits_parameters
)
self.directories[directory.id].snapshots_limits = SnapshotLimit(
manual_snapshots_current_count=snapshot_limit[
"SnapshotLimits"
]["ManualSnapshotsCurrentCount"],
manual_snapshots_limit=snapshot_limit["SnapshotLimits"][
"ManualSnapshotsLimit"
],
manual_snapshots_limit_reached=snapshot_limit[
"SnapshotLimits"
]["ManualSnapshotsLimitReached"],
)
except Exception as error:
logger.error(
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
except Exception as error:
logger.error(
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"