ghndrx/prowler
1
0
Fork 0
mirror of https://github.com/ghndrx/prowler.git synced 2026-02-10 14:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cloudtrail): list tags only in owned trails (#2025)

Browse Source
This commit is contained in:
Sergio Garcia
2023-03-02 16:16:19 +01:00
committed by GitHub
parent 24711a2f39
commit 467c5d01e9
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
prowler/providers/aws/services/cloudtrail/cloudtrail_service.py
View File

@@ -138,8 +138,11 @@ class Cloudtrail:
logger.info("CloudTrail - List Tags...")
try:
for trail in self.trails:
# Check if trails are in this region
if trail.region == trail.home_region:
# Check if trails are in this account and region
if (
trail.region == trail.home_region
and self.audited_account in trail.arn
):
regional_client = self.regional_clients[trail.region]
response = regional_client.list_tags(ResourceIdList=[trail.arn])[
"ResourceTagList"

2
tests/providers/aws/services/cloudtrail/cloudtrail_service_test.py
View File

@@ -4,7 +4,7 @@ from moto import mock_cloudtrail, mock_s3
from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info
from prowler.providers.aws.services.cloudtrail.cloudtrail_service import Cloudtrail
AWS_ACCOUNT_NUMBER = 123456789012
AWS_ACCOUNT_NUMBER = "123456789012"
class Test_Cloudtrail_Service: