fix(version): add timeout and check HTTP errors (#2886)

prowler/config/config.py

@@ -64,17 +64,16 @@ def check_current_version():
     try:
         prowler_version_string = f"Prowler {prowler_version}"
         release_response = requests.get(
-            "https://api.github.com/repos/prowler-cloud/prowler/tags"
+            "https://api.github.com/repos/prowler-cloud/prowler/tags", timeout=1
         )
         latest_version = release_response.json()[0]["name"]
         if latest_version != prowler_version:
             return f"{prowler_version_string} (latest is {latest_version}, upgrade for the latest features)"
         else:
             return f"{prowler_version_string} (it is the latest version, yay!)"
-    except Exception as error:
-        logger.error(
-            f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}] -- {error}"
-        )
+    except requests.RequestException:
+        return f"{prowler_version_string}"
+    except Exception:
         return f"{prowler_version_string}"
 
 

tests/config/config_test.py

@@ -17,7 +17,7 @@ MOCK_PROWLER_VERSION = "3.3.0"
 MOCK_OLD_PROWLER_VERSION = "0.0.0"
 
 
-def mock_prowler_get_latest_release(_):
+def mock_prowler_get_latest_release(_, **kwargs):
     """Mock requests.get() to get the Prowler latest release"""
     response = Response()
     response._content = b'[{"name":"3.3.0"}]'